Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for TypeScript's suggestion diagnostics #45378

Closed
mjbvz opened this issue Mar 9, 2018 · 1 comment
Closed

Support for TypeScript's suggestion diagnostics #45378

mjbvz opened this issue Mar 9, 2018 · 1 comment
Assignees
Labels
on-testplan plan-item VS Code - planned item for upcoming
Milestone

Comments

@mjbvz
Copy link
Collaborator

mjbvz commented Mar 9, 2018

See microsoft/TypeScript#22204

We need to support the new suggest diagnostics level from TypeScript. These diagnostics will be used to show places where a refactoring style code fix is available, such as convert es5 function to es6 class. We can also use these to indicate potential problems in files even if these are not errors or warnings, such as marking unused local even when noUnusedLocals is not set

This work item covers both the adoption of ts suggestion diagnostics plus the UX work on the vscode side to make sure we present these diagnostics well

@mjbvz mjbvz added the plan-item VS Code - planned item for upcoming label Mar 9, 2018
@mjbvz mjbvz added this to the March 2018 milestone Mar 9, 2018
@mjbvz mjbvz self-assigned this Mar 9, 2018
@mjbvz
Copy link
Collaborator Author

mjbvz commented Mar 20, 2018

Fixed by #45433

@mjbvz mjbvz closed this as completed Mar 20, 2018
@vscodebot vscodebot bot locked and limited conversation to collaborators May 4, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
on-testplan plan-item VS Code - planned item for upcoming
Projects
None yet
Development

No branches or pull requests

1 participant