Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support mac/linux/windows subkeys in keybindings.json the same as extensions.contributes.keybindings... #45679

Closed
joerohde opened this issue Mar 13, 2018 · 2 comments
Assignees
Labels
*duplicate Issue identified as a duplicate of another issue(s) keybindings VS Code keybinding issues
Milestone

Comments

@joerohde
Copy link

joerohde commented Mar 13, 2018

Issue Type: Feature Request

For users running on multiple machines/platforms, it is common to sync the vs settings. Without support for the default 'key' and override-platform-specific 'windows/mac/linux' subkeys, there's no good way to share keybindings.json.

Keeping multiple copies is a pain to keep in sync; and with the commonality of 'cmd' on Mac in particular, it's hard to have a true common config that works across platforms.

I may be underestimating the work, but it looks like the most tedious/difficult part would be extending the localization of the schema in keybindingservice.ts. :)

There does not seem to be a write model that would need to preserve the original values.
(writeKeybindingItem looked like it might be it, but it's generating very specific formatting for the Default Keybindings window. I guess it could be used by something more general and OS specific bindings would be lost?)

VS Code version: Code 1.21.0 (9a199d7, 2018-03-07T10:54:22.798Z)
OS version: Darwin x64 16.7.0

@vscodebot vscodebot bot added the keybindings VS Code keybinding issues label Mar 13, 2018
@tsalinger tsalinger added the feature-request Request for new features or functionality label Mar 14, 2018
@jrieken jrieken assigned alexdima and unassigned jrieken Mar 14, 2018
@joerohde
Copy link
Author

The attached PR #45995 has an implementation; and tests. I've attempted to make sure there are no downstream effects; but not being fluent in non-extension code, I won't claim it's ship ready.

@bpasero
Copy link
Member

bpasero commented Aug 7, 2018

Duplicate of #8962

@bpasero bpasero marked this as a duplicate of #8962 Aug 7, 2018
@bpasero bpasero closed this as completed Aug 7, 2018
@bpasero bpasero added this to the August 2018 milestone Aug 7, 2018
@alexdima alexdima added the *duplicate Issue identified as a duplicate of another issue(s) label Aug 28, 2018
@bpasero bpasero removed the feature-request Request for new features or functionality label Aug 28, 2018
@vscodebot vscodebot bot locked and limited conversation to collaborators Sep 21, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
*duplicate Issue identified as a duplicate of another issue(s) keybindings VS Code keybinding issues
Projects
None yet
Development

No branches or pull requests

5 participants