Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support TS options in quick fixes/refactoring #45948

Closed
mjbvz opened this issue Mar 16, 2018 · 2 comments
Closed

Support TS options in quick fixes/refactoring #45948

mjbvz opened this issue Mar 16, 2018 · 2 comments
Assignees
@mjbvz
Labels
feature-request Request for new features or functionality javascript JavaScript support issues on-testplan typescript Typescript support issues
Milestone
May 2018

Comments

@mjbvz
Copy link
Collaborator

mjbvz commented Mar 16, 2018

Tracks microsoft/TypeScript#20619

Problem
TS is adding a way to explicitly configure some aspects of quick fixes and refactorings. We need to add vscode settings to control these. Something like "typescript.quoteStyle": "single"

Current PR microsoft/TypeScript#22236
@mjbvz mjbvz added typescript Typescript support issues javascript JavaScript support issues labels Mar 16, 2018
@mjbvz mjbvz added this to the March 2018 milestone Mar 16, 2018
@mjbvz mjbvz self-assigned this Mar 16, 2018
@mjbvz mjbvz added the feature-request Request for new features or functionality label Mar 16, 2018
@mjbvz mjbvz mentioned this issue Mar 16, 2018
Closed
@mjbvz mjbvz modified the milestones: March 2018, April 2018 Mar 23, 2018
@mjbvz
Copy link
Collaborator Author

mjbvz commented Mar 23, 2018

This got pushed back to TS 2.8.2 so we'll have to hold off on it for another month

@alextreppass alextreppass mentioned this issue Mar 29, 2018
Closed
@mjbvz
Copy link
Collaborator Author

mjbvz commented Apr 3, 2018

Now pushed to 2.9 on the ts side

@mjbvz mjbvz modified the milestones: April 2018, May 2018 Apr 3, 2018
@mhegazy mhegazy mentioned this issue Apr 3, 2018
Closed
@mjbvz mjbvz closed this as completed in e1a4a68 May 2, 2018
@alextreppass alextreppass mentioned this issue May 15, 2018
Closed
@mjbvz mjbvz mentioned this issue May 25, 2018
Closed
3 tasks
@vscodebot vscodebot bot locked and limited conversation to collaborators Jun 17, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@mjbvz mjbvz

Labels
feature-request Request for new features or functionality javascript JavaScript support issues on-testplan typescript Typescript support issues
Projects
None yet
Milestone
May 2018
Development

No branches or pull requests
1 participant
@mjbvz