Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

do not show stackframe line information if source is missing #4608

Closed
weinand opened this issue Mar 23, 2016 · 2 comments
Closed

do not show stackframe line information if source is missing #4608

weinand opened this issue Mar 23, 2016 · 2 comments
Assignees
@weinand
Labels
debug Debug viewlet, configurations, breakpoints, adapter issues verified Verification succeeded
Milestone
May 2016

Comments

@weinand
Copy link
Contributor

weinand commented Mar 23, 2016

while verifying #4027:

if a stackframe has no source, it does not make sense to show the source line:
2016-03-23 12-20-35
@weinand weinand added the debug Debug viewlet, configurations, breakpoints, adapter issues label Mar 23, 2016
@isidorn
Copy link
Contributor

isidorn commented Mar 23, 2016

The source line in the call stack pane in debug viewlet? Screenshot?

@isidorn isidorn added this to the April 2016 milestone Mar 24, 2016
@isidorn isidorn assigned weinand and unassigned isidorn Mar 24, 2016
@weinand
Copy link
Contributor Author

weinand commented May 2, 2016 •
edited
Loading

@isidorn showing an empty badge looks a bit strange:

2016-05-02 12-18-47

I suggest to show 'unknown source' right aligned instead. Please make sure that the string is nls'ed (currently it is not).

@weinand weinand reopened this May 2, 2016
@weinand weinand assigned isidorn and unassigned weinand May 2, 2016
@weinand weinand modified the milestones: May 2016, April 2016 May 2, 2016
@isidorn isidorn closed this as completed in 7f18759 May 2, 2016
@isidorn isidorn assigned weinand and unassigned isidorn May 2, 2016
@weinand weinand added the verified Verification succeeded label May 27, 2016
@andrewcrawley andrewcrawley mentioned this issue Jul 13, 2016
Closed
@Gama11 Gama11 mentioned this issue Feb 14, 2017
Closed
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@weinand weinand

Labels
debug Debug viewlet, configurations, breakpoints, adapter issues verified Verification succeeded
Projects
None yet
Milestone
May 2016
Development

No branches or pull requests
2 participants
@weinand @isidorn