Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not pass all editors to extensions #46112

Closed
isidorn opened this issue Mar 19, 2018 · 1 comment
Closed

Do not pass all editors to extensions #46112

isidorn opened this issue Mar 19, 2018 · 1 comment
Assignees
Labels
debt Code quality issues release-notes Release notes issues
Milestone

Comments

@isidorn
Copy link
Contributor

isidorn commented Mar 19, 2018

Currently we have an issue that if an editor is registered in the modelService this editor will get passed to all the extensions via the api.
On the other hand if the editor is not registered in the modelService custom keybindings will not work and inteli-sene will not be supported.

We need a solution for an editor to not be passed to the extensions but still have custom keybdinings support and other editor goodnes.

Use cases: repl input, breakpoint widget, git commit input
Related: #10451

@alexandrudima could you provide some code pointers such that I can start looking into this.

@weinand fyi

@isidorn
Copy link
Contributor Author

isidorn commented Mar 20, 2018

Fixed via f470ce1

@isidorn isidorn closed this as completed Mar 20, 2018
@isidorn isidorn added the release-notes Release notes issues label Mar 26, 2018
@vscodebot vscodebot bot locked and limited conversation to collaborators May 4, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
debt Code quality issues release-notes Release notes issues
Projects
None yet
Development

No branches or pull requests

1 participant