Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: Add support for line and column numbers in the Go To File feature #4650

Closed
digeff opened this issue Mar 24, 2016 · 5 comments
Assignees
Labels
feature-request Request for new features or functionality verified Verification succeeded

Comments

@digeff
Copy link

digeff commented Mar 24, 2016

A lot of times I use the Go to File feature I'm copy pasting the file from another source (for example errors from TSLint or TypeScript) which in my case are of the format:
src\test\folder\other_folder\my_file.ts(9,9)

If I could paste that directly into the Go to File field, and I'd take me first to the file and then to the line (and maybe slightly highlight the line or something so I focus on that line directly) it'd be very useful.

Given that the way to specify line and column is probably dependent on the source, you'd probably need to either have some smart logic, or provide some setting in the user settings where I can define a regexp to match my case like:
[ { pattern: "((\d+),(\d+))$", lineAppearsFirst: true }]

@bpasero
Copy link
Member

bpasero commented Mar 24, 2016

This is some nice coincidence, I noticed this today as well and fixed for post-GA release: #4643

@bpasero bpasero closed this as completed Mar 24, 2016
@bpasero bpasero self-assigned this Mar 24, 2016
@bpasero bpasero added the feature-request Request for new features or functionality label Mar 24, 2016
@digeff
Copy link
Author

digeff commented Mar 24, 2016

@bpasero: Great minds think alike 👍

@egamma egamma mentioned this issue Apr 3, 2016
68 tasks
@aeschli
Copy link
Contributor

aeschli commented Apr 25, 2016

@bpasero Test plan item?

@bpasero
Copy link
Member

bpasero commented Apr 25, 2016

@aeschli assigned to Isidor as bug, don't think it needs a full test plan item.

@aeschli
Copy link
Contributor

aeschli commented Apr 25, 2016

@bpasero ok

@bpasero bpasero added the verified Verification succeeded label Apr 29, 2016
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature-request Request for new features or functionality verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

3 participants