Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test: improved process picker #46582

Closed
3 tasks done
weinand opened this issue Mar 26, 2018 · 0 comments
Closed
3 tasks done

Test: improved process picker #46582

weinand opened this issue Mar 26, 2018 · 0 comments
Labels
debug Debug viewlet, configurations, breakpoints, adapter issues testplan-item
Milestone

Comments

@weinand
Copy link
Contributor

weinand commented Mar 26, 2018

Test for #42521:

Complexity: 3

In this milestone we've have improved the Process Picker:

  • it does not only show node processes but also all processes that use the --debug or --inspector arguments (e.g. Electron's helper processes). So the picker can now deal both with process ids and inspector and debug ports.
    2018-03-18_19-21-47
  • the Process Picker bumps newer processes to the top of the list.
  • a new Attach to Node Process action that opens the process picker and attaches to a node process without a need for a launch config.

Verify:

  • use this "attach" launch with an embedded PickProcess command:
    {
      "type": "node",
      "request": "attach",
      "name": "Attach to Process via pid or port",
      "processId": "${command:PickProcess}"
    }
    
  • press F5 and verify that the picker correctly lists node.js or Electron processes with the correct arguments: all show process id, and when started with debug flags port and debug protocol is shown.
  • verify that the picker shows newer processes at the top
  • verify that you can attach to node.js or Electron processes if they are in debug mode (using the "--debug" or "--inspect flags")
  • verify that you can attach to a node.js process even if it is not in debug mode (uses the SIGUSR1 signal mechanism).
  • instead of using the launch config use the Attach to Node Process and try the same.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
debug Debug viewlet, configurations, breakpoints, adapter issues testplan-item
Projects
None yet
Development

No branches or pull requests

4 participants