Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fold block comments doesn't work #46653

Closed
jrieken opened this issue Mar 27, 2018 · 3 comments
Closed

Fold block comments doesn't work #46653

jrieken opened this issue Mar 27, 2018 · 3 comments
Assignees
@mjbvz
Labels
bug Issue identified by VS Code Team member as probable bug javascript JavaScript support issues typescript Typescript support issues upstream Issue identified as 'upstream' component related (exists outside of VS Code) verified Verification succeeded
Milestone
May 2018

Comments

@jrieken
Copy link
Member

jrieken commented Mar 27, 2018

re #46597

  • open /src/vs/base/common/arrays.ts
  • select F1 > Fold Block Comments
  • 🐛 block comments aren't folded
@mjbvz mjbvz added upstream Issue identified as 'upstream' component related (exists outside of VS Code) typescript Typescript support issues javascript JavaScript support issues labels Mar 27, 2018
@mjbvz
Copy link
Collaborator

mjbvz commented Mar 27, 2018

Duplicate of microsoft/TypeScript#22732

@mjbvz mjbvz marked this as a duplicate of microsoft/TypeScript#22732 Mar 27, 2018
@mjbvz mjbvz closed this as completed Mar 27, 2018
@mjbvz mjbvz added the *duplicate Issue identified as a duplicate of another issue(s) label Mar 27, 2018
@mjbvz
Copy link
Collaborator

mjbvz commented Mar 27, 2018

Whoops, duplicated the wrong issue. This one is about the Fold Block comment command

@mjbvz mjbvz reopened this Mar 27, 2018
@mjbvz mjbvz removed *duplicate Issue identified as a duplicate of another issue(s) upstream Issue identified as 'upstream' component related (exists outside of VS Code) labels Mar 27, 2018
@mjbvz mjbvz mentioned this issue Mar 27, 2018
Closed
@mjbvz mjbvz added bug Issue identified by VS Code Team member as probable bug upstream Issue identified as 'upstream' component related (exists outside of VS Code) labels Apr 2, 2018
@mjbvz mjbvz added this to the May 2018 milestone Apr 13, 2018
@mjbvz
Copy link
Collaborator

mjbvz commented May 7, 2018

Fixed by e628e8e. Currently also requires a build from TS master. We will pick up a TS insiders with the fix tomorrow.

@mjbvz mjbvz closed this as completed May 7, 2018
@jrieken jrieken added the verified Verification succeeded label May 30, 2018
@vscodebot vscodebot bot locked and limited conversation to collaborators Jun 21, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@mjbvz mjbvz

Labels
bug Issue identified by VS Code Team member as probable bug javascript JavaScript support issues typescript Typescript support issues upstream Issue identified as 'upstream' component related (exists outside of VS Code) verified Verification succeeded
Projects
None yet
Milestone
May 2018
Development

No branches or pull requests
2 participants
@jrieken @mjbvz