-
Notifications
You must be signed in to change notification settings - Fork 29.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Configuring extension tasks #46667
Comments
(Experimental duplicate detection) |
Basically you want a preExecute hook. If so it is a dup of #43782. And resolveTask is not meant to change task before execution. It is meant like in other resolve cases to fill in attributes that might be incomplete |
Actually I think it is more the other way around than in #43782. There it is about substituting parts of the task with values from inside the extension. I.e. replacing "${cpptools:activeConfig}" in strings for the build call. Here I would like to end up having simple configurable tasks in the tasks.json originating from the TaskProvider, where the user may provide different values.
After creating those the user should be able to change the value of The TaskProvider would then receive the configured task and return one where the Task execution is set to a computed commandLine. I must admit I currently don't understand why the Maybe #43782 and this version can use the same |
This actually would need a preExecute hook since the extension providing the bake task would need to change the executed command based on the set properties. |
Yes. But wasn't that also what perExecute would do? According to the comment in #43782:
Sounds like the place where the extension could also be given the task + updated task settings to update its execution command (after the variable substitution). |
duplicate of #58836 |
Thanks for creating this issue! We figured it's covering the same as another one we already have. Thus, we closed this one as a duplicate. You can search for existing issues here. See also our issue reporting guidelines. Happy Coding! |
Extensions should be able to use configured tasks with extension specific settings.
Currently when using a TaskProvider with provideTasks, the task configuration can be used to change problemFinders, console behavior and such.
It is not possible to have an extension specific settings that may be changed in the configuration.
The still not supported resolveTask method in TaskProvider does not quite do the trick (see #33523) as it seems to be intended to fill out incomplete tasks.
An example of task specific settings a user may want to overwrite would for instance be the number of used cores in parallel builds or similar custom settings (for an extension that wraps different embedded compilers).
The text was updated successfully, but these errors were encountered: