Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[css] path completion sometimes only works for one folder level #46722

Closed
gregvanl opened this issue Mar 27, 2018 · 3 comments
Closed

[css] path completion sometimes only works for one folder level #46722

gregvanl opened this issue Mar 27, 2018 · 3 comments
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug verified Verification succeeded
Milestone

Comments

@gregvanl
Copy link

  • VSCode Version: 1.22.0 Insiders
  • OS Version: Windows 10

Steps to Reproduce:

  1. In the vscode-docs repo and open inproduct-releasenotes.css.
  2. Try url() and trigger suggestions. You get a list of folders. Select "docs/".

There are no further suggestions to navigate the folder structure.

Found during testing #46537

@vscodebot vscodebot bot added the insiders label Mar 27, 2018
@gregvanl
Copy link
Author

image

@gregvanl
Copy link
Author

path suggestions do work if you use a relative path:

image

@gregvanl gregvanl changed the title CSS path completion only works for one folder level CSS path completion sometimes only works for one folder level Mar 27, 2018
@aeschli aeschli added this to the April 2018 milestone Mar 28, 2018
@aeschli aeschli changed the title CSS path completion sometimes only works for one folder level [css] path completion sometimes only works for one folder level Mar 28, 2018
@aeschli
Copy link
Contributor

aeschli commented Mar 28, 2018

The problem is that 'docs' is suggested.
docs is not relative to inproduct-releasenotes.css. but to the root folder.

I think the problem is with https://github.com/Microsoft/vscode/blob/dcc822dac11fa3fe3720739bfff703e6c15ad5fc/extensions/css-language-features/server/src/pathCompletion.ts#L58
That if is not necessary, he else case should work fine for that case too.

@aeschli aeschli modified the milestones: April 2018, March 2018 Mar 28, 2018
@aeschli aeschli added the bug Issue identified by VS Code Team member as probable bug label Mar 29, 2018
@gregvanl gregvanl added the verified Verification succeeded label Mar 30, 2018
@vscodebot vscodebot bot locked and limited conversation to collaborators May 13, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

3 participants