Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Indent not working properly for Ruby files #46838

Closed
AbhishekSharma20 opened this issue Mar 28, 2018 · 2 comments
Closed

Indent not working properly for Ruby files #46838

AbhishekSharma20 opened this issue Mar 28, 2018 · 2 comments
Assignees
Labels
editor-autoindent Editor auto indentation issues

Comments

@AbhishekSharma20
Copy link

AbhishekSharma20 commented Mar 28, 2018

Issue Type: Bug

for a Ruby file Indentation/collapse does'nt work properly as the end statements in comments are also considered.

eg:

class a
\#   def x
\#     ....
\#   end 
end

collapsing this will match first end(commented) with class tag.

VS Code version: Code 1.21.1 (79b44aa, 2018-03-14T14:46:47.128Z)
OS version: Windows_NT x64 10.0.15063

System Info
Item Value
CPUs AMD FX-9800P RADEON R7, 12 COMPUTE CORES 4C+8G (4 x 2695)
Memory (System) 7.47GB (3.16GB free)
Process Argv C:\Program Files\Microsoft VS Code\Code.exe
Screen Reader no
VM 0%
Extensions (5)
Extension Author (truncated) Version
solargraph cas 0.13.0
sftp lix 1.1.6
python ms- 2018.2.1
Ruby reb 0.17.0
autocomplete-english-word wus 0.1.6
Reproduces without extensions
@vscodebot vscodebot bot added editor editor-autoindent Editor auto indentation issues labels Mar 28, 2018
@dbaeumer
Copy link
Member

@aeschli assigning to you because of folding.

@aeschli
Copy link
Contributor

aeschli commented Mar 29, 2018

The current folding strategy is based purely on indentation.
In the near future, extensions can also provide syntax aware folding providers.
Duplicate of #3422

@aeschli aeschli closed this as completed Mar 29, 2018
@vscodebot vscodebot bot locked and limited conversation to collaborators May 13, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
editor-autoindent Editor auto indentation issues
Projects
None yet
Development

No branches or pull requests

3 participants