Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue Reporter: Don't show anything when no duplicates are found #46844

Closed
joaomoreno opened this issue Mar 28, 2018 · 3 comments
Closed

Issue Reporter: Don't show anything when no duplicates are found #46844

joaomoreno opened this issue Mar 28, 2018 · 3 comments
Assignees
@RMacfarlane
Labels
bug Issue identified by VS Code Team member as probable bug issue-reporter Issue reporter widget issues verified Verification succeeded
Milestone
April 2018

Comments

@joaomoreno
Copy link
Member

joaomoreno commented Mar 28, 2018 •
edited
Loading

Testing #46595

The No results found phrase pushes the whole UI down and caught me by surprise: I actually didn't know what that was about for a couple seconds.

image
@RMacfarlane
Copy link
Contributor

@joaomoreno Instead of removing it, what if it was just changed to No similar issues found? It seems useful to me to explicitly tell the user that we didn't find any duplicates. I experimented with adding some progress text that shows up when a search is being done, but because search is fast and debounced to every 300ms when typing, it just added a lot of ugly flashing. I think showing some sort of indicator that a search is being done would be a better experience though

@joaomoreno
Copy link
Member Author

Sure, works too

@RMacfarlane RMacfarlane added this to the April 2018 milestone Apr 3, 2018
@RMacfarlane RMacfarlane added issue-reporter Issue reporter widget issues bug Issue identified by VS Code Team member as probable bug labels Apr 3, 2018
@RMacfarlane
Copy link
Contributor

Changed text to No similar issues found and now only perform a search if there's text in title when title or description update.

@ramya-rao-a ramya-rao-a added the verified Verification succeeded label Apr 24, 2018
@vscodebot vscodebot bot locked and limited conversation to collaborators May 18, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@RMacfarlane RMacfarlane

Labels
bug Issue identified by VS Code Team member as probable bug issue-reporter Issue reporter widget issues verified Verification succeeded
Projects
None yet
Milestone
April 2018
Development

No branches or pull requests
3 participants
@joaomoreno @RMacfarlane @ramya-rao-a