Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Commit Amend destroys Signed-off-by (and potentially other fields) in commit message #47224

Closed
guw opened this issue Apr 5, 2018 · 3 comments
Assignees
Labels
*duplicate Issue identified as a duplicate of another issue(s)

Comments

@guw
Copy link
Contributor

guw commented Apr 5, 2018

  • VSCode Version: 1.21.1
  • OS Version: macOS 10.13.4

Steps to Reproduce:

  1. Do a Commit All (Signed Off)
  2. Do a Commit All (Amend)

On step 2 the commit message is collapsed into a single line. This is wrong. Any line breaks must be preserved because the the Signed-of-by field (as well as any other) needs to be separated from the commit message text by an empty line.

@vscodebot
Copy link

vscodebot bot commented Apr 5, 2018

@vscodebot vscodebot bot added the git GIT issues label Apr 5, 2018
@guw
Copy link
Contributor Author

guw commented Apr 5, 2018

Might be the same issue as #40295 (depending on the fix there)

@joaomoreno
Copy link
Member

Definitely!

@joaomoreno joaomoreno added *duplicate Issue identified as a duplicate of another issue(s) and removed git GIT issues labels Apr 5, 2018
@vscodebot vscodebot bot locked and limited conversation to collaborators May 20, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
*duplicate Issue identified as a duplicate of another issue(s)
Projects
None yet
Development

No branches or pull requests

2 participants