Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a setting to always enable the regular hover when debugging #47466

Closed
egamma opened this issue Apr 9, 2018 · 7 comments
Closed

Add a setting to always enable the regular hover when debugging #47466

egamma opened this issue Apr 9, 2018 · 7 comments
Assignees
Labels
extensions Issues concerning extensions
Milestone

Comments

@egamma
Copy link
Member

egamma commented Apr 9, 2018

Currently when debugging only the value hover is shown. We should provide a setting debug.showRegularHover which by default would be false.

@egamma egamma added the extensions Issues concerning extensions label Apr 9, 2018
@egamma egamma added this to the April 2018 milestone Apr 9, 2018
@isidorn
Copy link
Contributor

isidorn commented Apr 18, 2018

@guillaumejenkins just to check if this solution would work for the live share scenario, or you need a more fine grained solution?

As far as I understood you want to show the debug hover and all the other hovers (inlcuding live share) while debugging. If that is not your scenario please let me know

@guillaumejenkins
Copy link
Contributor

The desire was to make DecorationOptions.hoverMessage work while debugging, so that Live Share users could still hover remote cursors to see which participant they belong to. So, I do believe this would be good enough for Live Share scenarios.

Might I suggest making it an enum setting instead of a boolean? Something like:
debug.showHovers = "value" | "valueAndDecorations" | "all"

That way, if Live Share is going to override the setting, it can at least make the experience as non-intrusive as possible by only enabling one additional type of hovers instead of the full IntelliSense, which might get in the way while debugging.

@isidorn
Copy link
Contributor

isidorn commented Apr 18, 2018

@guillaumejenkins thanks for the suggestion however we do not differentiate hovers in the editor API. Thus the debug framework can not tell the editor to only show hovers of a certain type. Only the debug hover and everything else.
So the flag will probably be
debug.showEditorHover: true | false

@guillaumejenkins
Copy link
Contributor

Sounds good

@isidorn
Copy link
Contributor

isidorn commented Apr 20, 2018

After investigating, the issue is that if the regular hover is enabled during debugging the debug hover and the editor hover overlap (they are independent widgets unware of each other).

Moving this item to "On Deck" until the cascade team decides on our proposal.

screen shot 2018-04-20 at 16 17 58

@isidorn isidorn modified the milestones: April 2018, On Deck Apr 20, 2018
@guillaumejenkins
Copy link
Contributor

The proposal with hoverProvider is much better and is the right way to fix Name Tooltips during debugging. You can close this (unless it still makes sense outside of LiveShare)!

@isidorn
Copy link
Contributor

isidorn commented Apr 20, 2018

@guillaumejenkins Great, thanks. Closing

@isidorn isidorn closed this as completed Apr 20, 2018
@vscodebot vscodebot bot locked and limited conversation to collaborators Jun 4, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
extensions Issues concerning extensions
Projects
None yet
Development

No branches or pull requests

3 participants