Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Folder-level settings in a multi-root environment are unusable #47995

Closed
fabiospampinato opened this issue Apr 16, 2018 · 6 comments
Closed

Folder-level settings in a multi-root environment are unusable #47995

fabiospampinato opened this issue Apr 16, 2018 · 6 comments
Labels
*as-designed Described behavior is as designed

Comments

@fabiospampinato
Copy link
Contributor

If there is already an issue about this I wasn't able to find it

I have a folder/project inside a multi-workspace VSC window, this folder/project needs to provide a setting for an extension that it uses. Opening its .vscode/settings.json I see:

screen shot 2018-04-16 at 21 17 47

Sounds alright. I've added the setting and now I see:

bug

What does this even mean?

For what reason isn't the configuration object constructed like this?:

config = merge ( globalConfig, userConfig, workspaceConfig, rootConfig (this should change depending on which file I currently have the focus on) )

Unless I'm missing something obvious this seems badly broken to me, I basically can't use multi-root workspaces if I need to provide folder/project-specific settings to extensions, which is something I do need.

@ramya-rao-a
Copy link
Contributor

Please read https://code.visualstudio.com/docs/editor/multi-root-workspaces#_settings

If you want to provide folder/project-specific changes to settings from an extension, please log an issue in the repo for the said extension to make those settings resource specific.

@ramya-rao-a ramya-rao-a added the *as-designed Described behavior is as designed label Apr 17, 2018
@fabiospampinato
Copy link
Contributor Author

@ramya-rao-a Thanks for the reply. I wrote the extension in question, and I see no mention on how to mark a setting as a "resource" setting in the link you provided, nor here, where is this documented?

@ramya-rao-a
Copy link
Contributor

@fabiospampinato Its here: https://github.com/Microsoft/vscode/wiki/Extension-Authoring:-Adopting-Multi-Root-Workspace-APIs#settings

@gregvanl The above is linked only from Sept 2017 Release Notes. We should probably link it from other docs as well.

@fabiospampinato
Copy link
Contributor Author

@ramya-rao-a Thanks for the link. I think every piece of information that's written in there should also be available in the docs, otherwise what's the point of having docs if they only provide partial documentation.

@gregvanl
Copy link

There is a link under https://code.visualstudio.com/docs/editor/multi-root-workspaces#_extensions for extension authors. The wiki is mostly for migration (a one time event) but we'll look into porting any missing content into the main docs.

@fabiospampinato
Copy link
Contributor Author

@gregvanl I think a link under "User Guide" would be hard to find for extensions developers, I would expect to find that info under "Extensibility Reference" instead.

@vscodebot vscodebot bot locked and limited conversation to collaborators Jun 1, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
*as-designed Described behavior is as designed
Projects
None yet
Development

No branches or pull requests

3 participants