Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test: Custom SCM views #48429

Closed
3 tasks done
joaomoreno opened this issue Apr 23, 2018 · 3 comments
Closed
3 tasks done

Test: Custom SCM views #48429

joaomoreno opened this issue Apr 23, 2018 · 3 comments

Comments

@joaomoreno
Copy link
Member

joaomoreno commented Apr 23, 2018

Test for #45686:

Complexity: 4

Authors: @joaomoreno


There's a new view location scm:

  • As an extension developer, you can:
    • Contribute views to the SCM viewlet
    • Control view visibility using when contexts
  • As a user, you can:
    • Resize the views
    • Hide the views with context menu actions both in the views titles as well as the viewlet title area
    • Reorder contributed views
    • Still have multiple repositories selected as well as multiple contributed views visible simultaneously
@eamodio
Copy link
Contributor

eamodio commented Apr 24, 2018

@joaomoreno I tried this out with a quick and dirty version for GitLens, and at least on Windows everything looks good to me. Although I will note that I can't reorder the main Git view, nor can I hide it -- though I'm guessing that is on purpose.

@joaomoreno
Copy link
Member Author

@eamodio Thanks for testing! I've only enabled reordering among contributed views. Things would get overly complicated otherwise. But this isn't the last iteration for sure, let's see as we go along.

@eamodio
Copy link
Contributor

eamodio commented Apr 24, 2018

Makes perfect sense, I just wanted to mention it in case it wasn't on purpose :)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

5 participants