Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add # as trigger character for region completions in CSS/SCSS/LESS #48488

Closed
chrmarti opened this issue Apr 24, 2018 · 5 comments
Closed

Add # as trigger character for region completions in CSS/SCSS/LESS #48488

chrmarti opened this issue Apr 24, 2018 · 5 comments
Assignees
Labels
css-less-scss Issues and items concerning CSS,Less,SCSS styling verified Verification succeeded
Milestone

Comments

@chrmarti
Copy link
Contributor

Issue Type: Feature Request

Testing #48235

There are snippets for SCSS, it would make sense to have these for CSS and LESS too.

VS Code version: Code - Insiders 1.23.0-insider (b845ce9, 2018-04-24T05:10:57.500Z)
OS version: Darwin x64 16.7.0

@chrmarti chrmarti added the css-less-scss Issues and items concerning CSS,Less,SCSS styling label Apr 24, 2018
@vscodebot vscodebot bot added the insiders label Apr 24, 2018
@octref octref added this to the April 2018 milestone Apr 24, 2018
@octref octref reopened this Apr 26, 2018
@octref
Copy link
Contributor

octref commented Apr 26, 2018

@chrmarti What kind of snippet? We do have some for CSS/LESS.

snippet

@octref octref added info-needed Issue requires more information from poster and removed insiders labels Apr 26, 2018
@octref octref modified the milestones: April 2018, Backlog Apr 27, 2018
@chrmarti
Copy link
Contributor Author

Indeed, I must have missed these. Closing.

@octref
Copy link
Contributor

octref commented May 1, 2018

One thing I noticed, however, is when you type /* # the IntelliSense is not shown automatically. You need to manually trigger it. I can look into adding # as a completion trigger.

@octref octref reopened this May 1, 2018
@octref octref removed the info-needed Issue requires more information from poster label May 1, 2018
@octref octref changed the title Add region snippets for CSS and LESS Add # as trigger character for region completions in CSS/SCSS/LESS May 1, 2018
@octref
Copy link
Contributor

octref commented May 10, 2018

Actually we return a list of items that doesn't make sense for cases such as /* #| */. I'll look into supporting only region completions in comment (don't think there are other valid completions in there). And if we return empty results, people who have enabled word based suggestion could use that in comments.

@octref octref modified the milestones: Backlog, May 2018 May 10, 2018
@octref
Copy link
Contributor

octref commented May 14, 2018

For this one, we need to turn on this:

  "editor.quickSuggestions": {
    "comments": true
  }

Which we don't really do in any language servers, so closing.

@octref octref closed this as completed May 14, 2018
@Tyriar Tyriar added the verified Verification succeeded label May 30, 2018
@vscodebot vscodebot bot locked and limited conversation to collaborators Jun 28, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
css-less-scss Issues and items concerning CSS,Less,SCSS styling verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

3 participants