Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggestion: Support when for viewContainers contribution #48704

Closed
chrisdias opened this issue Apr 25, 2018 · 7 comments
Closed

Suggestion: Support when for viewContainers contribution #48704

chrisdias opened this issue Apr 25, 2018 · 7 comments
Assignees
Labels
*duplicate Issue identified as a duplicate of another issue(s) tree-views Extension tree view issues under-discussion Issue is under discussion for relevance, priority, approach
Milestone

Comments

@chrisdias
Copy link
Member

Suggest to support when clause for viewContainers contributions. This would let an extension author contribute a configuration that would let the user control if they want the explorer to be in a new view or in the default Explorer view.

@sandy081
Copy link
Member

sandy081 commented May 9, 2018

@chrisdias Can't you use the when clause on the view to show/hide in explorer and custom views container?

@eamodio
Copy link
Contributor

eamodio commented May 9, 2018

But just having the view contributed to the container causes the container to show up even if the view(s) are hidden. I brought this issue up on the main viewcontainers when it was being added.

@vbfox
Copy link
Contributor

vbfox commented May 10, 2018

@eamodio I asked for the auto-hiding if the container contains nothing here #49145 let's hope we get a way or another to hide empty activities

@sandy081
Copy link
Member

@eamodio Yes, view container will be empty in such cases and I am thinking to hide view container if there are no views are registered or all registered views are hidden by when clause.

If agreed, I would make this and #49145 as duplicates

@vbfox
Copy link
Contributor

vbfox commented May 15, 2018

Having reflected a little more about it, I think #49145 (hiding when no views are visible inside) could be better than a when cause.

I like the when clause direct approach but the problem is that activities are shared between extensions (Azure ones for example do that) and any direct interaction mean that multiple extensions might need to collaborate. (If an extension for language A decide to hide the test activity, other languages contributing to it would have their views hidden..).

@sandy081
Copy link
Member

Duplicate of #49145

@sandy081 sandy081 marked this as a duplicate of #49145 May 28, 2018
@sandy081 sandy081 added the *duplicate Issue identified as a duplicate of another issue(s) label May 28, 2018
@vscodebot
Copy link

vscodebot bot commented May 28, 2018

Thanks for creating this issue! We figured it's covering the same as another one we already have. Thus, we closed this one as a duplicate. You can search for existing issues here. See also our issue reporting guidelines.

Happy Coding!

@vscodebot vscodebot bot closed this as completed May 28, 2018
@vscodebot vscodebot bot locked and limited conversation to collaborators Jul 12, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
*duplicate Issue identified as a duplicate of another issue(s) tree-views Extension tree view issues under-discussion Issue is under discussion for relevance, priority, approach
Projects
None yet
Development

No branches or pull requests

4 participants