Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to colorize action icons in views #48751

Closed
ghost opened this issue Apr 26, 2018 · 3 comments
Closed

Allow to colorize action icons in views #48751

ghost opened this issue Apr 26, 2018 · 3 comments
Labels
*duplicate Issue identified as a duplicate of another issue(s) feature-request Request for new features or functionality icons-product Issues for in-product icons themes Color theme issues

Comments

@ghost
Copy link

ghost commented Apr 26, 2018

  • VSCode Version: 1.22.2
  • OS Version: macOs

Currently, there is no ability to colorize action labels in scm viewlet and it's impossible to see them with different colors. See screenshot below.

image

@vscodebot vscodebot bot added the git GIT issues label Apr 26, 2018
@joaomoreno joaomoreno added feature-request Request for new features or functionality themes Color theme issues and removed git GIT issues labels Apr 27, 2018
@joaomoreno
Copy link
Member

Yeah, unfortunately that applies to pretty much most of the workbench. Those actions are contributed with two sets of icons: for dark theme and for light theme.

We don't have the notion of themeable contributed icons, as far as I know. cc @bpasero @aeschli

@joaomoreno joaomoreno added this to the Backlog milestone Apr 27, 2018
@joaomoreno joaomoreno removed their assignment Apr 27, 2018
@bpasero bpasero changed the title ability to colorize action labels in scm viewlet Allow to colorize action labels in views Apr 27, 2018
@bpasero bpasero removed this from the Backlog milestone Apr 27, 2018
@bpasero bpasero changed the title Allow to colorize action labels in views Allow to colorize action icons in views Sep 11, 2018
@bpasero
Copy link
Member

bpasero commented Oct 10, 2019

//cc @misolori

@miguelsolorio miguelsolorio added the icons-product Issues for in-product icons label Oct 10, 2019
@miguelsolorio
Copy link
Contributor

We already do this in the tree view (see #55857 ) but extension contributions have yet to get this. Closing this in favor of #31466 because that's the only way for extensions to get colorization in icons is re-using our icons/icon font.

@miguelsolorio miguelsolorio added the *duplicate Issue identified as a duplicate of another issue(s) label Oct 10, 2019
@github-actions github-actions bot locked and limited conversation to collaborators Jun 1, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
*duplicate Issue identified as a duplicate of another issue(s) feature-request Request for new features or functionality icons-product Issues for in-product icons themes Color theme issues
Projects
None yet
Development

No branches or pull requests

3 participants