"window.restoreWindows": "folders" doesn't work under Linux

[MrChriZ]

• VSCode Version:Version 1.22.2
• OS Version:Linux Mint 18.3

Steps to Reproduce:

1. Set "window.restoreWindows": "folders"
2. Close Code
3. Relaunch code
4. Only one Window reopens.

Does this issue occur when all extensions are disabled?: Yes

[bpasero]

@MrChriZ video proof please

[MrChriZ]

OK Slightly different -- here's a video of it not working in Windows which is running under a VM on my Linux setup. It was easier to demonstrate code being closed unexpectedly here by killing the VM:

https://www.youtube.com/watch?v=NDwZtpLgOA0&feature=youtu.be

This is a clean install of code.

[MrChriZ]

Something more nuanced is going on under Linux
I setup the Red and Blue folder test this time under Windows and code worked as expected.

I opened two Ember projects I'm working on and killed code and then reopened and it instead reopened my red / blue folders I had opened previously.

https://www.youtube.com/watch?v=Tc9AgbWlTSE&feature=youtu.be

[MrChriZ]

It dawned on me that there may be some kind of timer which waits for a while before saving the folder set and so causing the results I'm seeing.
As such I've just retested the Windows system - this time leaving code with the red and blue folder set left open for 30 minutes prior to an unexpected system restart. Code still opened a different folder set than the one I had opened for 30 minutes prior to unexpected system restart.

Linux however is behaving more as expected with this method of testing however.. I'll keep working to see if I can reproduce my issues which are usually caused when the battery on my laptop runs out of juice prior to the operating system shutting down in an orderly fashion.

[MrChriZ]

So I tried again opening two folders sets in Linux. I interacted with both flicking through different files.
I then left them for around 5 minutes. Prior to a restart which I video'd.
Now please excuse the shakey hand video - but I don't have a VM set up for Linux and I can't screen record a full system restart.

https://www.youtube.com/watch?v=jDS-DnSnP6A

Again Code does not open the correct folder set.
At the start of the video 0:06 in the top window I have my RedPill folder open.
When I reopen code 0:54 in the top window code reopens my EmberJS folder.
The bottom window I believe opened the correct folder... but opens with a different file.

[bpasero]

@MrChriZ wait a sec, you "power off" the machine while VS Code is running and expect it to restore all windows then? I think there is a high likelyhood that this kills VS Code without having a chance to persist any data. VS Code needs a normal shutdown for this feature to work.

Can you please reproduce this issue by opening 2 folders, then selecting File > Quit and then starting again?

[MrChriZ]

"VS Code needs a normal shutdown for this feature to work."
Why? Chrome manages to remember which tabs I had opened in a similar setup.
Android Studio returns to exactly the state you last used it in.

It can't be that hard to remember which folders were last opened (at the point they were opened)?

[bpasero]

Yeah agreed, so marking as duplicate of #12058

[MrChriZ]

Thanks did search but didn't see that one.