Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

command to open New Window on open workspace #49346

Closed
isidorn opened this issue May 7, 2018 · 5 comments
Closed

command to open New Window on open workspace #49346

isidorn opened this issue May 7, 2018 · 5 comments
Assignees
@isidorn
Labels
feature-request Request for new features or functionality on-testplan release-notes Release notes issues
Milestone
May 2018

Comments

@isidorn
Copy link
Contributor

isidorn commented May 7, 2018

No description provided.

@isidorn isidorn added the feature-request Request for new features or functionality label May 7, 2018
@isidorn isidorn added this to the May 2018 milestone May 7, 2018
@isidorn isidorn self-assigned this May 7, 2018
@kieferrm kieferrm mentioned this issue May 7, 2018
Closed
46 tasks
@isidorn
Copy link
Contributor Author

isidorn commented May 9, 2018

After investigating into this I have found that this already exists as a command
Workspaces: Open Folder as Workspace in New Window and behaves as I would expect.

Closing since this seems to work as expected - we just need to advertise this command a bit more.

@egamma please let me know if you had something else on mind and I can reopen this.

openworkspace

@isidorn isidorn closed this as completed May 9, 2018
@isidorn isidorn removed the feature-request Request for new features or functionality label May 9, 2018
@isidorn
Copy link
Contributor Author

isidorn commented May 10, 2018 •
edited
Loading

Noticed that his command only works for single folder -> reopening to also respect multi root workspaces.
Will also rename it to "Duplicate Workspace in New Window" - feedback on name very welcome

@isidorn isidorn reopened this May 10, 2018
@isidorn isidorn added feature-request Request for new features or functionality verification-needed Verification of issue is requested labels May 10, 2018
@bpasero
Copy link
Member

bpasero commented May 10, 2018

@isidorn I like it! should probably maybe not be enabled/work if the workspace is empty?

@isidorn
Copy link
Contributor Author

isidorn commented May 10, 2018 •
edited
Loading

@bpasero thanks! I excplitiy allowed for that since people might get used to that command as always opening a workspace, not sure why not to allow that case and make the user use another command.
I do not find the current behavior counter intuitive

@bpasero
Copy link
Member

bpasero commented May 10, 2018

@isidorn oke

@isidorn isidorn added on-testplan and removed verification-needed Verification of issue is requested labels May 15, 2018
@isidorn isidorn mentioned this issue May 15, 2018
Closed
2 tasks
@isidorn isidorn added the release-notes Release notes issues label Jun 1, 2018
@vscodebot vscodebot bot locked and limited conversation to collaborators Jun 24, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@isidorn isidorn

Labels
feature-request Request for new features or functionality on-testplan release-notes Release notes issues
Projects
None yet
Milestone
May 2018
Development

No branches or pull requests
2 participants
@bpasero @isidorn