Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Node.js debugging async emitHookFactory #49402

Closed
Cellule opened this issue May 7, 2018 · 4 comments
Closed

Node.js debugging async emitHookFactory #49402

Cellule opened this issue May 7, 2018 · 4 comments
Assignees

Comments

@Cellule
Copy link

Cellule commented May 7, 2018

Issue Type: Feature Request

While debugging node.js with async function, I often end up in the function emitHookFactory from the node internal scripts.
The debugging experience would be better if that function was skipped as it has no value to the user.

VS Code version: Code 1.22.2 (3aeede7, 2018-04-12T16:38:45.278Z)
OS version: Windows_NT x64 10.0.17665

@vscodebot
Copy link

vscodebot bot commented May 7, 2018

(Experimental duplicate detection)
Thanks for submitting this issue. Please also check if it is already covered by an existing one, like:

@isidorn isidorn assigned roblourens and unassigned isidorn May 8, 2018
@roblourens
Copy link
Member

roblourens commented May 9, 2018

You can! Just add

"skipFiles": [
    "<node_internals>/**"
],

To your launch config and you will skip through those files, same as "blackboxing" using chrome devtools.

@Cellule
Copy link
Author

Cellule commented May 9, 2018

Would you consider making this the default with a launch configuration of type node ?

@roblourens
Copy link
Member

Possibly. Need to do some thinking around this and also microsoft/vscode-chrome-debug-core#245

@vscodebot vscodebot bot locked and limited conversation to collaborators Jun 23, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants