Auto attach causing issues when debugging in integrated terminal

[roblourens]

• enable auto attach
• Start a basic node launch config with "console": "integratedTerminal".
• Wait 10s
• Get an error that we couldn't attach to the process, and I assume that it has detected the same process that I am currently debugging:

Was this always the case? We could somehow suppress this particular error in this case.

[rsweetland]

I think this is isolated it to commands that spawn more than one node process.

For example, nodemon server.js spawns two node processes which you can see with ps -a | grep node.

Starting in the debugger nodemon server.js --inspect-brk apparently spawns two node processes, each with --inspect-brk appended. VS Code seems to be trying to attach to both of them, with the second one timing out after 10 seconds.

When I just use node server.js --inspect-brk it spawns only one process which VS Code properly handles.

I ran into the issue myself with mocha -w mocha --require (Edit: turns out --require was the culprit)

A quick fix might be to expose a timeout preference allowing for an "infinite" value. That would allow continued debugging of child processes. This is assuming that VS code continues to guess the right process to connect to, which is has each time for me.

[weinand]

fixed by:

• ignoring auto-attach requests when a debug config launch is under way for the integrated terminal
• suppressing attach timeouts for auto-attach launch configurations

[isidorn]

I still see this with latest insiders following @roblourens steps -> reopening

[weinand]

Since I cannot reproduce, please provide more details:

• platform
• program you are using
• screenshot of the error

And make sure that you are using version 1.27.5 of node-debug (legacy)

[isidorn]

OS X, latest insiders
Node 8.9.1

Program I am using
console.log('test')

I am not using node-debug (legacy). I am using node2.
Unfortunetly I can not repro anymore (only saw it once).
Since I can no longer repro it is fine to close this if you want to and I will reopen if I see it again

[weinand]

The auto attach code lives only in node-debug (legacy) and is shared with node-debug2.

How does you launch config look like?

[isidorn]

{
            "type": "node",
            "request": "launch",
            "name": "Launch Program",
            "program": "${workspaceFolder}/hey.js",
            "console": "integratedTerminal"
        }

[weinand]

and you have a breakpoint on line 1 of hey.js?

[isidorn]

Yes I do

[isidorn]

Tried around 10 times now, and still can not repro.

[weinand]

it is ok if you stop after 1000... ;-)

[isidorn]

😊

[weinand]

After trying another 837 times, I was able to reproduce (and analyse the problem in the debugger).
There was a name mismatch between the property name emitted by node-debug ("__autoAttached") and the corresponding code in VS Code ("__autoAttach") .

[isidorn]

Verified via code review and that I can still not repro :)