Test prompts for non-core language packs

[ramya-rao-a]

Test for #45663

• Mac @chrisdias
• any @sandy081

Complexity: 2

Below are the non-core languages for which we have language packs in the marketplace

• pt-br (Portuguese (Brazil))
• tr (Turkish)
• bg (Bulgarian)
• hu (hungarian)

Steps:

• Change OS locale to any one of the above (In Windows, you will have to install the OS language pack)
• Close all instances of VS Code
• Open VS Code. You should be prompted about the existence of a language pack in the marketplace.
• Test both Install, Install and Restart and the Don't show me again options.

Change the OS locale back to English, change locale in VS Code using the Configure Display Language command. and repeat the above tests.

[ramya-rao-a]

Note to testers: The prompts will be in English until the below is done by @danyeh and his team.

@danyeh To test this feature end to end, we need the language packs for the non-core languages to

• include translations for the file vs/platform/node/minimalTranslations
• be published using the latest version of the vsce tool (1.41.0)

Is it possible to get this done by say Wednesday?

[ramya-rao-a]

@sandy081 Did you test on Windows or some other OS?

[danyeh]

Update list of non-core languages for which we have language packs in the marketplace

• pt-br (Portuguese (Brazil))
• tr (Turkish)
• bg (Bulgarian)
• hu (hungarian)

[danyeh]

bg and hu have translation ready. Will finish publish and test by Wednesday.

[danyeh]

@ramya-rao-a , I tested on Windows OS by following the steps. I don't see any prompt (not even in English). Any other hint?
Here is what I did.

• Windows 10 - 1709
• Install pt-br, bg OS language pack.
• Set input method, display language, Language for non-Unicode programs to one of the language (either pt-br or bg)
• Install and/or launch VS Code 1.24.0-Insiders.
• Nothing happened. Checked recommended extension: Only VSTS show up.

[chrisdias]

@danyeh make sure you don't have a locale.json in %APPDATA%\Code - Insiders\User

[ramya-rao-a]

@danyeh Did you restart your machine after setting the display language? Also, like @chrisdias said, ensure you dont have the locale.json file. Even if you do, ensure its empty or set to the locale you are testing.

[danyeh]

Now I can see there is prompt but not the one we expect. Here is detail.
Steps:

• Windows 10 - 1709
• Install pt-br, bg OS language pack.
• Set input method, display language, Language for non-Unicode programs to one of the language (either pt-br or bg)
• Uninstall VS Code 1.24.0-Insiders. Delete AppData\Roaming\Code - Insiders; Delete %userprofile%.vscode-insiders
• Reboot
• Install VS Code 1.24.0-Insiders.

Result:

• Prompt in English
  
• Click Install and Restart
• VS Code restarted as bg language UI
• There steps repro on pt-br too.

Examine resource file:

• Go to %userprofile%.vscode-insiders
• Check main.i18n.json
• Translation exist.
  

[ramya-rao-a]

@danyeh Did you publish the extension using the latest version of the vsce tool?

[danyeh]

My colleague did the publish. He confirmed vsce version is 1.41.0

[ramya-rao-a]

@joaomoreno This commit was made after the vsce tool was published. We need this for the core translations to appear as an asset. Can you publish another version?

@danyeh Sorry about that. Once @joaomoreno publishes the next version of the vsce tool, you/your team will have to get that version and re-publish the non-core language packs.

[sandy081]

@ramya-rao-a I tested on Windows. VSCE had an issue if the path started with . and @joaomoreno fixed it on Tuesday. May be he would have forgotten to publish.

I used a test extension to test it. Its here - https://marketplace.visualstudio.com/items?itemName=sandy081.999-pack1

Edit: I also tested for the prompt with pt-br language pack (https://marketplace.visualstudio.com/items?itemName=MS-CEINTL.vscode-language-pack-pt-BR). Labels were still in english because the lang pack was not yet adopted.

[joaomoreno]

Oh yeah, I did not publish. On the way: https://travis-ci.org/Microsoft/vscode-vsce/builds/386056427

[ramya-rao-a]

Thanks @joaomoreno @sandy081

@danyeh Can you re-publish the language packs for the below locales using the 1.41.1 version of the vsce tool?

• pt-br (Portuguese (Brazil))
• tr (Turkish)
• bg (Bulgarian)
• hu (hungarian)

[danyeh]

Pulled latest translation from Transifex and re-published requested 4 languages with vsce 1.41.1.
Version of new language pack is 1.24.2.
Suggest to test with bg or hu.

[ramya-rao-a]

Thanks @danyeh!

[ramya-rao-a]

@chrisdias Marking this test item as complete as per our discussions offline