Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split terminal multiple times very slugish #50627

Closed
isidorn opened this issue May 29, 2018 · 6 comments
Closed

Split terminal multiple times very slugish #50627

isidorn opened this issue May 29, 2018 · 6 comments
Assignees
Labels
*as-designed Described behavior is as designed help wanted Issues identified as good community contribution opportunities terminal Integrated terminal issues
Milestone

Comments

@isidorn
Copy link
Contributor

isidorn commented May 29, 2018

Refs: #50499

I do not think this is conected to dom rendering of the terminal.
Open terminal:
Click on the split termianl like 10 times very fast -> whole vscode is slugish for the next minute and there are some visual glitches.
If this action is so heavy I would expect that it gets disabled while a new terminal is initatialising

@isidorn isidorn added the terminal Integrated terminal issues label May 29, 2018
@Tyriar
Copy link
Member

Tyriar commented May 29, 2018

I can't seem to repro a particular perf problem on mac or Windows, there's a slow down for a few seconds which is expected but everything is fine after that. I do notice some glitches on mac which might be worth looking into though.

@Tyriar Tyriar added bug Issue identified by VS Code Team member as probable bug help wanted Issues identified as good community contribution opportunities labels May 29, 2018
@Tyriar Tyriar added this to the Backlog milestone May 29, 2018
@isidorn
Copy link
Contributor Author

isidorn commented May 29, 2018

This might also be connected to the fact that I use zshell

@Tyriar
Copy link
Member

Tyriar commented May 29, 2018

@isidorn oh-my-zsh?

@Tyriar
Copy link
Member

Tyriar commented May 29, 2018

That shouldn't affect perf while idle though 😕

@isidorn
Copy link
Contributor Author

isidorn commented May 29, 2018

@Tyriar yes

@Tyriar
Copy link
Member

Tyriar commented Jun 25, 2018

Closing this as there isn't really a fix that I'd want to do apart from improving the speed of the terminal (which is something that's always being looked into). Disabling the action while split is happening would be annoying as I often quickly hit ctrl+shift+5 twice to split twice.

@Tyriar Tyriar closed this as completed Jun 25, 2018
@Tyriar Tyriar added the *as-designed Described behavior is as designed label Jun 25, 2018
@isidorn isidorn removed the bug Issue identified by VS Code Team member as probable bug label Jun 28, 2018
@vscodebot vscodebot bot locked and limited conversation to collaborators Aug 9, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
*as-designed Described behavior is as designed help wanted Issues identified as good community contribution opportunities terminal Integrated terminal issues
Projects
None yet
Development

No branches or pull requests

2 participants