Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Settings: folder/workspace settings tab should hide settings that cannot be applied #50641

Closed
bpasero opened this issue May 29, 2018 · 6 comments
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug settings-editor VS Code settings editor issues verified Verification succeeded
Milestone

Comments

@bpasero
Copy link
Member

bpasero commented May 29, 2018

Refs: #50496

When I click on folder or workspace settings, I always seem to be seeing all settings. But some settings (like update.channel) cannot be applied in any other scope and so should not be visible.

@octref
Copy link
Contributor

octref commented May 29, 2018

Presentation wise I suggest greying those setting out and have a hover-tip that explains it.
Main motivation is with search I still want to see all matches.

@roblourens
Copy link
Member

Yeah I can match the current editor by hiding them, or do something else. We can cover this in our user study around settings scope issues.

@roblourens roblourens added bug Issue identified by VS Code Team member as probable bug settings-editor VS Code settings editor issues labels May 29, 2018
@roblourens roblourens added this to the June 2018 milestone May 29, 2018
@octref
Copy link
Contributor

octref commented May 29, 2018

@roblourens Currently failed edit still successfully updates the GUI. But I guess you can address that together with this issue:
image

@bpasero
Copy link
Member Author

bpasero commented Aug 28, 2018

This is very broken now.

Scenario 1:

  • open settings
  • click "Workspace"
  • search for "Window"
  • click on "Window" settings in the tree
  • click on "User"

=> workspace settings still showing

Scenario 2:

  • open settings
  • click on "Window" settings in tree
  • search for "Window"
  • click on "Window" settings in tree
  • click on "Workspace"

=> all "User" settings show up even though I clicked "Workspace"

@bpasero bpasero reopened this Aug 28, 2018
@bpasero bpasero added the verification-found Issue verification failed label Aug 28, 2018
@roblourens
Copy link
Member

Fixed with #57352

@roblourens roblourens removed the verification-found Issue verification failed label Aug 29, 2018
@bpasero
Copy link
Member Author

bpasero commented Aug 30, 2018

@roblourens ok works better now, the selection in the TOC is still lost when switching between user and workspace setting.

@bpasero bpasero added the verified Verification succeeded label Aug 30, 2018
@vscodebot vscodebot bot locked and limited conversation to collaborators Oct 13, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug settings-editor VS Code settings editor issues verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

3 participants