Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Settings: Show highlight of match #50714

Closed
octref opened this issue May 29, 2018 · 4 comments
Closed

Settings: Show highlight of match #50714

octref opened this issue May 29, 2018 · 4 comments
Assignees
Labels
*out-of-scope Posted issue is not in scope of VS Code settings-editor VS Code settings editor issues under-discussion Issue is under discussion for relevance, priority, approach

Comments

@octref
Copy link
Contributor

octref commented May 29, 2018

#50496

Currently words in search query aren't highlighted, as they are in the json editor.

@roblourens
Copy link
Member

This is by design actually, since the highlights are distracting and misleading when they don't included the synonyms and misspelled matches that bing search gives us.

@octref
Copy link
Contributor Author

octref commented May 29, 2018

It would still be quite useful - when I type a word I want to know which part of the description / setting name it matches against. For cases like misspell or fooBar should match both foo and bar, we can try to handle them more gracefully (maybe ask Bing to return synonym / matched word info), but just the simple exact match would already be quite useful.

@roblourens
Copy link
Member

maybe ask Bing to return synonym / matched word info

We did try this but there were too many false positives and it was a bit noisy. I'll leave this open, maybe a less eye-catching highlight would help. But in user studies we saw people skipping results that didn't have a bright orange highlight, even when it was the correct answer.

@roblourens roblourens added settings-editor VS Code settings editor issues under-discussion Issue is under discussion for relevance, priority, approach labels May 29, 2018
@roblourens roblourens added the *out-of-scope Posted issue is not in scope of VS Code label Sep 13, 2018
@vscodebot
Copy link

vscodebot bot commented Sep 13, 2018

This iteration we focus on issue grooming. This issue is being closed to keep the number of issues in our inbox on a manageable level, we are closing issues that are not going to be addressed in the foreseeable future: We look at the number of votes the issue has received and the number of duplicate issues filed. More details here. If you disagree and feel that this issue is crucial: We are happy to listen and to reconsider.

If you wonder what we are up to, please see our roadmap and issue reporting guidelines.

Thanks for your understanding and happy coding!

@vscodebot vscodebot bot closed this as completed Sep 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
*out-of-scope Posted issue is not in scope of VS Code settings-editor VS Code settings editor issues under-discussion Issue is under discussion for relevance, priority, approach
Projects
None yet
Development

No branches or pull requests

2 participants