Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

more options for custom view #50861

Closed
maziac opened this issue May 31, 2018 · 9 comments
Closed

more options for custom view #50861

maziac opened this issue May 31, 2018 · 9 comments
Assignees
Labels
*dev-question VS Code Extension Development Question *extension-candidate Issue identified as good extension implementation

Comments

@maziac
Copy link

maziac commented May 31, 2018

Hi,
I'm not sure if this is areally a feature request or if I missed something.

For my debug-adapter I would like to add a view to the side bar that displays memory contents.
So the user gets the ability to read memory and also edit memory.

It should look similar to this:

image

I have found that I can contribute a view and make data available via the TreeDataProvider but that does not suit my needs as the memory dump is no tree.

Is there any possibility to add something different than a tree to a view?

Please note: I don't necessarily need an update of the debug-api offering more options for the 'view' would be sufficient.

@isidorn
Copy link
Contributor

isidorn commented May 31, 2018

Custom views are currently not supporting this.
Forwarding to @sandy081 since this might be a duplicate of an already open feature request

@isidorn isidorn assigned sandy081 and unassigned isidorn May 31, 2018
@sandy081
Copy link
Member

@maziac What kind of view/model are you looking at? At present we support Tree (tree + list) model.

@sandy081 sandy081 added the info-needed Issue requires more information from poster label May 31, 2018
@maziac
Copy link
Author

maziac commented May 31, 2018

As you can see from the picture I would require lines with columns.
In the end every item (i.e. the 2 digit hex numbers like 5F) should be editable.

@sandy081
Copy link
Member

I see. We have web views which are still in preview mode. I think that is the right approach for your use case. But web views are shown in editor and not in side bar. I think this view might not be a good fit in side bar. Check this - #43713

@maziac
Copy link
Author

maziac commented May 31, 2018

I'm not sure if this can help.
a) it's not in the side view (although I might could live with it but)
b) it's a preview. I.e. I would like to edit values in there.

@sandy081 sandy081 assigned mjbvz and unassigned sandy081 May 31, 2018
@sandy081
Copy link
Member

IMO this is not a good fit for side bar and for tree view.

@mjbvz Please advise if it can be done through web view.

Thanks.

@mjbvz
Copy link
Collaborator

mjbvz commented May 31, 2018

Yes this would be a good fit for a webview. Webviews can only go in editor positions currently. We may also allow them in sidebars at some point (#46585) but no promises on that

Webviews can contain editors, UI, previews, pretty much anything. Here are the docs: https://code.visualstudio.com/docs/extensions/webview

@mjbvz mjbvz closed this as completed May 31, 2018
@mjbvz mjbvz added *dev-question VS Code Extension Development Question *extension-candidate Issue identified as good extension implementation and removed info-needed Issue requires more information from poster labels May 31, 2018
@maziac
Copy link
Author

maziac commented Jun 1, 2018

Hmm, I tried to use the web vieew as described in the tutorial, but it does nto work:
createWebView is not defined:
image

Does it have something to do with the fact that my extension is a debug adapter?

@mjbvz
Copy link
Collaborator

mjbvz commented Jun 1, 2018

You have an old vscode.d.ts file. Update the vscode entry in the engine section of your package.json to 1.23 and run install again

Please ask extension dev over on stack overflow in the future so that they can help other people too

@vscodebot vscodebot bot locked and limited conversation to collaborators Jul 15, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
*dev-question VS Code Extension Development Question *extension-candidate Issue identified as good extension implementation
Projects
None yet
Development

No branches or pull requests

4 participants