Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Grid: Implement "Centered Editor Layout" #50936

Closed
bpasero opened this issue Jun 1, 2018 · 1 comment · Fixed by #52064
Closed

Grid: Implement "Centered Editor Layout" #50936

bpasero opened this issue Jun 1, 2018 · 1 comment · Fixed by #52064
Assignees
Labels
on-testplan workbench-editor-grid Grid layout issues in the editor area
Milestone

Comments

@bpasero
Copy link
Member

bpasero commented Jun 1, 2018

We should restore the functionality we had. Ideally the code we used to have could be encapsulated into a widget that has these features:

  • sashes to the left and right with a container in the center
  • sashes move on both sides if one side is dragged
  • some way to persist and restore view state

Having this widget, we can throw it into an editor group view based on the condition that centered editor layout is enabled or not.

@bpasero bpasero added the workbench-editor-grid Grid layout issues in the editor area label Jun 1, 2018
@bpasero bpasero added this to the June 2018 milestone Jun 1, 2018
@isidorn
Copy link
Contributor

isidorn commented Jun 1, 2018

Yeah this makes perfect sense. I can look into it next week.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
on-testplan workbench-editor-grid Grid layout issues in the editor area
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants