Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Menu is not read out by NVDA #51841

Closed
AccessibilityTestingTeam-TCS opened this issue Jun 14, 2018 · 12 comments
Closed

Menu is not read out by NVDA #51841

AccessibilityTestingTeam-TCS opened this issue Jun 14, 2018 · 12 comments
Assignees
Labels
a11ymas Issue from accessibility team accessibility Keyboard, mouse, ARIA, vision, screen readers (non-specific) issues menus Menu items and widget issues windows VS Code on Windows issues

Comments

@AccessibilityTestingTeam-TCS

Environment Details:
VSCode Version : 1.24.1
OS Version : Win10

Additional Details:
ScreenReader/NVDA[2018.2],JAWS[18.0.5038],MAS1.3.1

Repro Steps:
1.Launch VS Code while NVDA is ON.
2.Navigate to "Menu Bar" at top of the screen after login.
3.Using "Alt+F,Alt+E,Alt+S" these keys navigate to menu bar.
3.Observed that, NVDA is not reading selected menu name of menu bar.

Actual:
While using "Alt+F" key then keyboard focus is on the "File" menu of MenuBar.
but NVDA is not reading it's name as "File".
NVDA is reading it as "Menu SubMenu"

Same issue is observed in JAWS

Expected:
NVDA should read the name of selected Menu name.
Here, NVDA should read it like "File Menu" then "Submenu name"
instead of "Menu Submenu"

Recommendations:
Refer below link which is repository of bug fixes code snippets:
https://microsoft.sharepoint.com/teams/msenable/mas/pages/browse-fixes.aspx

User Impact:
If NVDA is not reading the selected menu name then user will not know which menu is selected and which menu is selected from the menubar.

MAS Reference:
https://microsoft.sharepoint.com/:w:/r/teams/msenable/_layouts/15/WopiFrame.aspx?sourcedoc={54f28d1f-a2d1-4dcd-84e1-5c9b87e8aba4}

Attachment For Reference:
[Accessibility]A11y_VSCode_MenuBar_ScreenReader.pptx

Does this issue occur when all extensions are disabled?: Yes

@RMacfarlane RMacfarlane added the accessibility Keyboard, mouse, ARIA, vision, screen readers (non-specific) issues label Jun 14, 2018
@isidorn
Copy link
Contributor

isidorn commented Jul 3, 2018

@sbatten this should be fixed with the new custom menu, correct? Assinging to july for discussion

@isidorn isidorn added this to the July 2018 milestone Jul 3, 2018
@isidorn isidorn changed the title [Accessibility]A11y_VSCode_MenuBar_ScreenReader: NVDA is not reading the selected menu name such as "File,Edit" etc Menu is not read out by NVDA Jul 3, 2018
@isidorn isidorn added the menus Menu items and widget issues label Jul 5, 2018
@sbatten
Copy link
Member

sbatten commented Jul 17, 2018

Menu titles are read out now using the custom menubar, but I am not sure if this meets the requirement because this does not happen when the menu is launched via mnemonics. That's because the first menu item is focused and NVDA only reads its aria-label. However, pressing the alt-key focuses the menubar and allows you to navigate the menus and learn the shortcuts. In this way, I believe it meets the accessibility requirements. Awaiting more info.

@isidorn
Copy link
Contributor

isidorn commented Jul 18, 2018

@sbatten I feel like the menu is still work in progress, thus moving this issue out to August when we can focus on the missing accessibility in the menu.
@AccessibilityTestingTeam-TCS can you please try this out with latest vscode insiders from here https://code.visualstudio.com/insiders/ and check if this is fixed now. Thanks

@vscodebot vscodebot bot closed this as completed Jul 25, 2018
@vscodebot
Copy link

vscodebot bot commented Jul 25, 2018

This issue has been closed automatically because it needs more information and has not had recent activity. See also our issue reporting guidelines.

Happy Coding!

@isidorn
Copy link
Contributor

isidorn commented Jul 26, 2018

Let's reopen to give more time to the @AccessibilityTestingTeam-TCS to reply

@isidorn isidorn reopened this Jul 26, 2018
@vscodebot vscodebot bot closed this as completed Aug 2, 2018
@vscodebot
Copy link

vscodebot bot commented Aug 2, 2018

This issue has been closed automatically because it needs more information and has not had recent activity. See also our issue reporting guidelines.

Happy Coding!

@sbatten sbatten reopened this Aug 2, 2018
@AccessibilityTestingTeam-TCS
Copy link
Author

Here NVDA is reading only the "Menu Submenu" only but not reading it's name such as if user enter "alt+f,alt+e" then nvda is not announcing what menu get selected such as whether it is "File Menu" or "Edit Menu" etc.

@sbatten
Copy link
Member

sbatten commented Aug 23, 2018

@AccessibilityTestingTeam-TCS I don't believe this was tested with the new custom menu, but this one was: #17172 and appears to be the same symptoms. My reply there holds for this issue as well.

@bpasero bpasero modified the milestones: August 2018, September 2018 Aug 30, 2018
@vscodebot vscodebot bot closed this as completed Sep 6, 2018
@vscodebot
Copy link

vscodebot bot commented Sep 6, 2018

This issue has been closed automatically because it needs more information and has not had recent activity. See also our issue reporting guidelines.

Happy Coding!

@sbatten sbatten reopened this Sep 6, 2018
@AccessibilityTestingTeam-TCS
Copy link
Author

@sbatten While we press Alt key, NVDA reads name and shortcuts for all menu items and navigates them using arrow keys, seems this fulfills the needed requirements.

@sbatten
Copy link
Member

sbatten commented Sep 19, 2018

Awesome, thanks for the feedback. Closing as resolved.

@sbatten sbatten closed this as completed Sep 19, 2018
@sbatten sbatten removed the info-needed Issue requires more information from poster label Sep 19, 2018
@chrmarti chrmarti added the a11ymas Issue from accessibility team label Oct 2, 2018
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 3, 2018
@isidorn isidorn added the windows VS Code on Windows issues label Jan 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
a11ymas Issue from accessibility team accessibility Keyboard, mouse, ARIA, vision, screen readers (non-specific) issues menus Menu items and widget issues windows VS Code on Windows issues
Projects
None yet
Development

No branches or pull requests

6 participants