Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search: NVDA reads name of each combobox two times #52015

Closed
AccessibilityTestingTeam-TCS opened this issue Jun 15, 2018 · 4 comments
Closed
Assignees
Labels
a11ymas Issue from accessibility team bug Issue identified by VS Code Team member as probable bug *duplicate Issue identified as a duplicate of another issue(s) search Search widget and operation issues upstream Issue identified as 'upstream' component related (exists outside of VS Code) windows VS Code on Windows issues
Milestone

Comments

@AccessibilityTestingTeam-TCS

Environment Details:
VSCode Version : 1.23.1
OS Version : Win10

Additional Details:
MAS Violated : MAS 1.3.1
ScreenReader Versions : NVDA2018.1.1

Repro Steps:

  1. Launch VS Code while NVDA is ON.
  2. Navigate to Activity Bar and select "Search"(Cntrl+Shift+F) button.
  3. Navigate to "Match Case" , "Match Whole Word" , "Use RegEx","Use Exclude settings and Ignore Files", "Replace All" comboboxes using "Tab".
  4. Search any text say "abc" in Search textbox and hit "Enter". No valid results are found which is read by NVDA.

Actual:
NVDA reads the name of each combobox(naviagted using "Tab" key) and also content "No results found. Review..." thrice.

Expected:
NVDA should read the content and name of controls only once to the user when navigated using "Tab".

Recommendations:
Refer below link which is repository of bug fixes code snippets:
https://microsoft.sharepoint.com/teams/msenable/mas/pages/browse-fixes.aspx

User Impact:
Screenreader users will get unnecessary extra information if controls and content are read thrice.

MAS Reference:
MAS 1.3.1 - https://microsoft.sharepoint.com/teams/msenable/_layouts/15/WopiFrame.aspx?sourcedoc={54f28d1f-a2d1-4dcd-84e1-5c9b87e8aba4}

Attachment For Reference:
A11y_VSCode_ViewSearch_ScreenReader_ReadsThrice.pptx

Does this issue occur when all extensions are disabled?: Yes

@vscodebot vscodebot bot added the search Search widget and operation issues label Jun 15, 2018
@roblourens roblourens added bug Issue identified by VS Code Team member as probable bug accessibility Keyboard, mouse, ARIA, vision, screen readers (non-specific) issues labels Jun 18, 2018
@isidorn isidorn changed the title [Accessibility]A11y_VSCode_ViewSearch_ScreenReader: NVDA reads name of each combobox (navigated using "Tab")and also content after search- "Thrice". Search: NVDA reads name of each combobox and also content after search three times Jul 5, 2018
@isidorn isidorn changed the title Search: NVDA reads name of each combobox and also content after search three times Search: NVDA reads name of each combobox two times Jul 5, 2018
@isidorn
Copy link
Contributor

isidorn commented Jul 5, 2018

Tab into search combo boxes - each time nvda reads it's title two times. I can repro only on win.

@roblourens
Copy link
Member

roblourens commented Sep 1, 2018

Upstream nvaccess/nvda#7841

See #51992

@roblourens roblourens added the upstream Issue identified as 'upstream' component related (exists outside of VS Code) label Sep 1, 2018
@isidorn isidorn added this to the Backlog milestone Sep 20, 2018
@chrmarti chrmarti added the a11ymas Issue from accessibility team label Oct 2, 2018
@cleidigh cleidigh added accessibility-nvda and removed accessibility Keyboard, mouse, ARIA, vision, screen readers (non-specific) issues labels Oct 12, 2018
@isidorn
Copy link
Contributor

isidorn commented Jan 24, 2019

Let's close as dup of #51992

@isidorn isidorn closed this as completed Jan 24, 2019
@isidorn isidorn added the *duplicate Issue identified as a duplicate of another issue(s) label Jan 24, 2019
@vscodebot vscodebot bot locked and limited conversation to collaborators Mar 13, 2019
@isidorn isidorn added the windows VS Code on Windows issues label Jan 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
a11ymas Issue from accessibility team bug Issue identified by VS Code Team member as probable bug *duplicate Issue identified as a duplicate of another issue(s) search Search widget and operation issues upstream Issue identified as 'upstream' component related (exists outside of VS Code) windows VS Code on Windows issues
Projects
None yet
Development

No branches or pull requests

5 participants