Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test: Grid Editor Layout smoke test #52334

Closed
2 tasks done
bpasero opened this issue Jun 19, 2018 · 1 comment
Closed
2 tasks done

Test: Grid Editor Layout smoke test #52334

bpasero opened this issue Jun 19, 2018 · 1 comment

Comments

@bpasero
Copy link
Member

bpasero commented Jun 19, 2018

Complexity: 3

The grid editor layout feature was already tested last milestone extensively (see #50458) but there were still quite a bit of changes going in during this milestone. The idea is to do some exploratory testing to ensure we have not introduced new bugs by ensuring:

  • you can create editor layouts and sizing works good and is preserved across reloads
  • there are no exceptions in the console when working with the grid overall
  • try with normal text editors, diff editors, settings editor and webview
    • side-by-side and settings editor have different size constraints, to try resizing them to their minimum sizes

2x2

The 2x2 grid is newly implemented:

  • You can enable it via View > Editor Layout > Grid (2x2)
  • Test that the sashes are connected
  • Test that as soon as the grid structure changes, the 2x2 behaviour is dropped
  • Test that everything is persisted on reload
  • Test that editor minimum widths/heights are respected (eg. the settings editor has a larger minimum width/height than regular editors)
@rebornix
Copy link
Member

It works as expected during my testing with markdown preview, zen mode, centered editors, diff view, etc. I really like it.

@vscodebot vscodebot bot locked and limited conversation to collaborators Aug 10, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants