Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test Custom View API improvements #52806

Closed
2 tasks done
sandy081 opened this issue Jun 25, 2018 · 5 comments
Closed
2 tasks done

Test Custom View API improvements #52806

sandy081 opened this issue Jun 25, 2018 · 5 comments

Comments

@sandy081
Copy link
Member

sandy081 commented Jun 25, 2018

Refs: #48198 #49311 #50662

Complexity: 2

Write an extension that contributes a tree view to the Explorer. Refer to documentation and ftpExplorer.

  • Test listening to onDidChangeSelection event when the selection changes.
  • Test visible property and the corresponding onDidChangeVisibility event are working as expected when the tree view contents are visible or not. NOTE: visible is false when the tree view is collapsed.
  • Test passing focus flag to reveal api and make sure that revealed element is focused - reveal(element: T, options?: { select?: boolean, focus?: boolean }): Thenable<void>;
@sandy081 sandy081 added this to the June 2018 milestone Jun 25, 2018
@weinand
Copy link
Contributor

weinand commented Jun 26, 2018

@sandy081 Writing an extension can only have a complexity of 3 and more...

@isidorn
Copy link
Contributor

isidorn commented Jun 26, 2018

@sandy081 please provide an extension that is creating a tree view, since the one you attached is not using the new createTreeView api.
Writing a new extension that does all this seems like a much higher compleixty
Thanks

@weinand
Copy link
Contributor

weinand commented Jun 26, 2018

@isidorn I've updated https://github.com/weinand/vscode-processes to the new API. You can use this as a sample.

@isidorn
Copy link
Contributor

isidorn commented Jun 26, 2018

@weinand thanks!

@sandy081
Copy link
Member Author

@isidorn FTP Explorer uses the Tree view implementation. Updated the description to use that sample.

@isidorn isidorn removed their assignment Jun 26, 2018
@isidorn isidorn closed this as completed Jun 26, 2018
@vscodebot vscodebot bot locked and limited conversation to collaborators Aug 10, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants