Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dragging files and folders onto an empty explorer ignores the files #52875

Open
jrieken opened this issue Jun 26, 2018 · 3 comments
Open

Dragging files and folders onto an empty explorer ignores the files #52875

jrieken opened this issue Jun 26, 2018 · 3 comments
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug file-explorer Explorer widget issues
Milestone

Comments

@jrieken
Copy link
Member

jrieken commented Jun 26, 2018

re #52292

  • in the finder select a file and a folder
  • drop them onto an empty explorer
  • 🐛 only the folder is opened, the file is being ignored
@jrieken
Copy link
Member Author

jrieken commented Jun 26, 2018

The same is true for the file and workspace-file combination.

@isidorn isidorn added the bug Issue identified by VS Code Team member as probable bug label Jun 26, 2018
@isidorn isidorn added this to the June 2018 milestone Jun 26, 2018
@isidorn
Copy link
Contributor

isidorn commented Jun 27, 2018

This is how the dropHandlerhandles this.
@bpasero do you want to look into fixing this, or should I, or was there a specific reason you implemented it this way?

@isidorn isidorn added the under-discussion Issue is under discussion for relevance, priority, approach label Jun 27, 2018
@isidorn isidorn removed this from the June 2018 milestone Jun 27, 2018
@bpasero
Copy link
Member

bpasero commented Jun 27, 2018

@isidorn feel free to change that logic but make it configurable as needed to see if that use case makes sense for the places where the drop handler is being used:

  • open editors view
  • empty explorer view
  • dropping into the tabs control
  • dropping into a tab
  • dropping into an editor or empty editor group

@isidorn isidorn added this to the Backlog milestone Jun 27, 2018
@isidorn isidorn removed the under-discussion Issue is under discussion for relevance, priority, approach label Jun 27, 2018
@isidorn isidorn added the file-explorer Explorer widget issues label Oct 14, 2019
@isidorn isidorn assigned JacksonKearl and unassigned isidorn Aug 12, 2021
@lramos15 lramos15 assigned lramos15 and unassigned JacksonKearl May 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issue identified by VS Code Team member as probable bug file-explorer Explorer widget issues
Projects
None yet
Development

No branches or pull requests

5 participants