Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Javascript updating imports when change name change node_modules packages #53109

Closed
aigic opened this issue Jun 27, 2018 · 1 comment
Closed

Javascript updating imports when change name change node_modules packages #53109

aigic opened this issue Jun 27, 2018 · 1 comment
Assignees
@mjbvz
Labels
*duplicate Issue identified as a duplicate of another issue(s) javascript JavaScript support issues

Comments

@aigic
Copy link

aigic commented Jun 27, 2018

Issue Type: Bug

Hi , I wanted a change name of a js(to be descriptive a vuex module) file and and vs code (Insiders) suggested me to change the name of imports too.After accepting I saw vs code changed some files in node_modules.(Obviously there were no imports of that file in my packages:).)
I think it would be a good idea to exclude node_module path from this feature.

Thanks for nice app

VS Code version: Code - Insiders 1.25.0-insider (b7e6e04, 2018-06-22T05:11:25.722Z)
OS version: Darwin x64 17.5.0
@vscodebot vscodebot bot added the javascript JavaScript support issues label Jun 27, 2018
@mjbvz
Copy link
Collaborator

mjbvz commented Jun 27, 2018

Duplicate of #51970

Added workaround on the VS Code side. Should be the newest insiders

@mjbvz mjbvz closed this as completed Jun 27, 2018
@mjbvz mjbvz added the *duplicate Issue identified as a duplicate of another issue(s) label Jun 27, 2018
@vscodebot vscodebot bot locked and limited conversation to collaborators Aug 11, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@mjbvz mjbvz

Labels
*duplicate Issue identified as a duplicate of another issue(s) javascript JavaScript support issues
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mjbvz @aigic