Editor buffers readonly status doesn't change after changing file system provider

[IlyaBiryukov]

Issue Type: Bug

1. In extension, register a custom read-only FileSystemProvider.
2. In VSCode open a file from that work space. The file will open read only as expected.
3. In extension dispose of the file system provider and re-register another one for the same scheme, this time not read-only.
4. Run workbench.files.action.refreshFilesExplorer command.

Expected:
The editor changes and becomes read-write.

Actual:
The editor stays read-only, even if I close it and re-open it.

VS Code version: Code - Insiders 1.25.0-insider (5d6156a, 2018-06-25T09:40:10.343Z)
OS version: Windows_NT x64 10.0.16299

System Info

Item	Value
CPUs	Intel(R) Core(TM) i7-6700 CPU @ 3.40GHz (8 x 3408)
GPU Status	2d_canvas: enabled flash_3d: enabled flash_stage3d: enabled flash_stage3d_baseline: enabled gpu_compositing: enabled multiple_raster_threads: enabled_on native_gpu_memory_buffers: disabled_software rasterization: disabled_software video_decode: enabled video_encode: enabled vpx_decode: enabled webgl: enabled webgl2: enabled
Memory (System)	31.92GB (12.25GB free)
Process Argv	C:\Program Files\Microsoft VS Code Insiders\Code - Insiders.exe C:\src\cascade\vscode\extension
Screen Reader	no
VM	0%

Extensions (3)

Extension	Author (truncated)	Version
cpptools	ms-	0.17.5
csharp	ms-	1.15.2
vsliveshare	ms-	0.4.0-dev

[vscodebot]

(Experimental duplicate detection)
Thanks for submitting this issue. Please also check if it is already covered by an existing one, like:

• Open readonly files as readonly editors (#52337)
• Readonly workspace folders (#51585)
• Suggestion: append a "Read-only" label in the editor tabs for files that are read only (#53022)

[isidorn]

Thanks for creating these issues. I will look into this in July
fyi @jrieken

[jrieken]

@isidorn The is this event that you should listen on: https://github.com/Microsoft/vscode/blob/ab21dfa0a9c56e05f3f4f380f16d4b1b673961a2/src/vs/platform/files/common/files.ts#L47

[isidorn]

@jrieken thanks, on that event I need to clear my explorer model it seems

[jrieken]

yeah, maybe. tho I'd say you are mostly driven by the workspace config (which should probably listen to this event)

[isidorn]

@jrieken I found it weird that the workspace context service fires an onDidChangeWorkspaceFolders once a new file system provider is registered. For now I decided to listen on that event directly from explorer.