TS rename causes many type definitions files to open for NPM packages

[kyle-mccarthy]

With "typescript.updateImportsOnFileMove.enabled" setting set to "always", after renaming a TS file, many TS definitions files from NPM packages will open. When going to close the .d.ts files, VS code will think a change was made and prompt to save the package file.

• VSCode Version: Version 1.24.1 (1.24.1)
• OS Version: MacOS High Sierra 10.13.5 (17F77)

Steps to Reproduce:

1. Open TS file in project
2. Rename open file
3. Many definitions files from NPM packages open after change

Does this issue occur when all extensions are disabled?: Yes

It seemed similar to #53186 but the trigger and result are different.

[vscodebot]

(Experimental duplicate detection)
Thanks for submitting this issue. Please also check if it is already covered by an existing one, like:

• Allow to reveal a symlinked file from the editor in the explorer (#34713)

[mjbvz]

Does this reproduce in the latest VS Code build with all extensions disabled? I recently made a fix for this but it is only in insiders

[kyle-mccarthy]

@mjbvz I just tried it out and while it didn't open any type def files, it opened several unrelated project files.

[mjbvz]

Please try upgrading your workspace to use typescript@next by following these instructions. Do you still see this issue after upgrading?

[mjbvz]

Closing as duplicate of microsoft/TypeScript#24914. The next VS Code insiders will include this fix. Let me know if you still see this issue when using TypeScript 3.0+ in your workspace