Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shortcut problem with the new custom titleBarStyle #53654

Closed
mrahhal opened this issue Jul 6, 2018 · 3 comments · Fixed by #56617
Closed

Shortcut problem with the new custom titleBarStyle #53654

mrahhal opened this issue Jul 6, 2018 · 3 comments · Fixed by #56617
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug verified Verification succeeded
Milestone

Comments

@mrahhal
Copy link
Contributor

mrahhal commented Jul 6, 2018

  • VSCode Version: 1.25.0
  • OS Version: Windows 10

I have very valuable shortcuts assigned to Alt+D (and Alt+A and the likes). When I enable the new custom titleBarStyle, pressing Alt+D now makes the "Debug" menu active without executing the shortcut. This used to work in the native title. Interestingly, Alt+Shift+D still works.

I'm in love with the new custom title, but there's no way I can enable it with this shortcut not working.

@vscodebot vscodebot bot added the new release label Jul 6, 2018
@mrahhal mrahhal changed the title Alt+D shortcut problem with the new custom titleBarStyle Shortcut problem with the new custom titleBarStyle Jul 6, 2018
@zurkoxxx
Copy link

zurkoxxx commented Jul 6, 2018

try setting:
"window.enableMenuBarMnemonics": false

@mrahhal
Copy link
Contributor Author

mrahhal commented Jul 6, 2018

Thanks! That worked. I myself don't care about the menu's mnemonics so I'll just disable it. But the issue can be resolved in a more appropriate way.

@vscodebot vscodebot bot removed the new release label Jul 10, 2018
@sbatten sbatten added workbench-menu debt Code quality issues labels Jul 10, 2018
@sbatten sbatten added bug Issue identified by VS Code Team member as probable bug and removed debt Code quality issues labels Aug 8, 2018
@sbatten sbatten added this to the August 2018 milestone Aug 8, 2018
@monk-time
Copy link

monk-time commented Aug 17, 2018

I agree that it would be great to have the ability to re-use menubar shortcuts without disabling enableMenuBarMnemonics completely. That's how it works in the current legacy menu: redefined shortcuts execute their actions without opening the menu. But it seems that both actions happen at once with the new menu.

For example:

  1. Enable "window.titleBarStyle": "custom".
  2. Add { "key": "alt+f", "command": "editor.action.selectAll", "when": "textInputFocus" } to keybinding.json.
  3. Press Alt+F.

What happens: the text gets selected, but the "File" menu also opens and grabs the focus to itself.

Sometimes though it works differently: I use the GitLens extension that assigns a number of very common actions to Alt+* shortcuts in its non-default "alt-based" shortcut scheme. When I press Alt+H ("Show File History"), the menu opens and closes very briefly before the extension takes over and shows its UI for this action.

@bpasero bpasero added the verified Verification succeeded label Aug 30, 2018
@vscodebot vscodebot bot locked and limited conversation to collaborators Oct 2, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug verified Verification succeeded
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants