Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support DAP's terminate request when ending a debug session #54384

Closed
weinand opened this issue Jul 16, 2018 · 2 comments
Closed

Support DAP's terminate request when ending a debug session #54384

weinand opened this issue Jul 16, 2018 · 2 comments
Assignees
Labels
debug Debug viewlet, configurations, breakpoints, adapter issues feature-request Request for new features or functionality on-testplan release-notes Release notes issues
Milestone

Comments

@weinand
Copy link
Contributor

weinand commented Jul 16, 2018

To fix issue microsoft/vscode-node-debug#1 we will add this feature to VS Code:

  • if a debug adapter supports "terminate", VS Code's red terminate button will first send a "terminate" request to the DA (which some DAs might implement by sending a SIGINT signal to the debuggee). VS Code remembers in its debug session state that a "terminate" request has been issued.
  • If the debuggee has no SIGINT handler, the debuggee will terminate and end the debug session. This is almost identical to the current behaviour.
  • if the debuggee has a SIGINT handler but doesn't terminate properly, the debug session will continue. Pressing the red terminate button again will send a "disconnect" request. This will kill the debuggee forcefully (like the current behaviour).

@isidorn I've added a terminate to VA Code's DAP.

@weinand weinand added feature-request Request for new features or functionality debug Debug viewlet, configurations, breakpoints, adapter issues labels Jul 16, 2018
@weinand weinand added this to the July 2018 milestone Jul 16, 2018
@isidorn
Copy link
Contributor

isidorn commented Jul 16, 2018

I have pushed the inital changes needed for this.
We still only have one action "Debug: Stop" which when invoked only once sends the terminate request (if the capability is supported). Otherwise if the capability is not supported, or if triggered for the second time sends a "disconnect".

Things to keep an eye open for: sessions staying around when debugging is over. Also extensinos host debugging, restarting and reloading. I tested this out but we should test more.

@isidorn isidorn added the verification-needed Verification of issue is requested label Jul 16, 2018
@weinand
Copy link
Contributor Author

weinand commented Jul 17, 2018

@isidorn this request should not be used for attach debug configs. I've created #54420 for this.

@isidorn isidorn added on-testplan and removed verification-needed Verification of issue is requested labels Jul 23, 2018
@weinand weinand added the release-notes Release notes issues label Aug 3, 2018
@vscodebot vscodebot bot locked and limited conversation to collaborators Aug 30, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
debug Debug viewlet, configurations, breakpoints, adapter issues feature-request Request for new features or functionality on-testplan release-notes Release notes issues
Projects
None yet
Development

No branches or pull requests

2 participants