Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do NOT re-sort QuickPickItem when typing #54400

Closed
ThisIsManta opened this issue Jul 16, 2018 · 5 comments
Closed

Do NOT re-sort QuickPickItem when typing #54400

ThisIsManta opened this issue Jul 16, 2018 · 5 comments
Assignees
Labels
*duplicate Issue identified as a duplicate of another issue(s) feature-request Request for new features or functionality quick-pick Quick-pick widget issues

Comments

@ThisIsManta
Copy link

Originally, the quick pick comprises index, actionType, reducer, and selector respectively. I intentionally place index at the top of the list because, you know, it is index.js. However, when start typing, VSCode re-sorts my items so actionType comes before index which I do NOT want that.

I believe auto sorting QuickPickItem is a feature (#15659), hence I'm creating a feature request ticket so that QuickPickOptions has a new field called keepOrder or doNotResort or whatever.

Cheers!

2018-07-16_21-32-48

@Tyriar
Copy link
Member

Tyriar commented Jul 16, 2018

I guess what's being asked for here is to make sure the entries stay stable if they have the same weight after going through the fuzzy sort. @chrmarti is the weighted list sorted using a stable sort?

@Tyriar Tyriar added the quick-pick Quick-pick widget issues label Jul 16, 2018
@chrmarti chrmarti added the feature-request Request for new features or functionality label Jul 16, 2018
@ThisIsManta
Copy link
Author

ThisIsManta commented Jul 16, 2018

Thanks Daniel for your swift response.

Unfortunately, I would like have my order untouched whether the search term matches label or description.

@Tyriar
Copy link
Member

Tyriar commented Jul 16, 2018

@ThisIsManta the order must be changed as it's fuzzy sorting and filtering the list. Without sorting, if you had something that matched the label exactly and the description partially the best match may not be at the top. In the example above I would expect the match weights to be the same as they're both matching on the description.

@chrmarti
Copy link
Contributor

/duplicate #73904

@vscodebot vscodebot bot added the *duplicate Issue identified as a duplicate of another issue(s) label Oct 31, 2019
@vscodebot
Copy link

vscodebot bot commented Oct 31, 2019

Thanks for creating this issue! We figured it's covering the same as another one we already have. Thus, we closed this one as a duplicate. You can search for existing issues here. See also our issue reporting guidelines.

Happy Coding!

@vscodebot vscodebot bot closed this as completed Oct 31, 2019
@vscodebot vscodebot bot locked and limited conversation to collaborators Dec 16, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
*duplicate Issue identified as a duplicate of another issue(s) feature-request Request for new features or functionality quick-pick Quick-pick widget issues
Projects
None yet
Development

No branches or pull requests

3 participants