Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test new smartStep behavior #54919

Closed
2 tasks done
weinand opened this issue Jul 24, 2018 · 0 comments
Closed
2 tasks done

Test new smartStep behavior #54919

weinand opened this issue Jul 24, 2018 · 0 comments
Labels
debug Debug viewlet, configurations, breakpoints, adapter issues testplan-item
Milestone
July 2018

Comments

@weinand
Copy link
Contributor

weinand commented Jul 24, 2018 •
edited by JacksonKearl
Loading

Refs: microsoft/vscode-chrome-debug-core#245

Complexity: 3

Authors: @weinand, @roblourens

In this release we have slightly changed the behaviour of the "smartStep" feature of node-debug.

Previously "smartStep" would skip over JavaScript code in these two cases:

  • JavaScript transpiled from source that could not be successfully mapped back to the source via the source map. Typically this is generated helper code created for some language feature not available in the target language which has no corresponding language construct in the source language.
  • JavaScript that is not transpiled at all (and has no source map).

With this release "smartStep" only skips JavaScript in the first case.
This makes it easier to debug into plain JavaScript (e.g. libraries).

Verify that "smartStep" no longer skips over JavaScript code that was not transpiled (and is not associated with a source map).
@weinand weinand added debug Debug viewlet, configurations, breakpoints, adapter issues testplan-item labels Jul 24, 2018
@weinand weinand added this to the July 2018 milestone Jul 24, 2018
@isidorn isidorn assigned chrmarti and unassigned RMacfarlane Jul 31, 2018
@chrmarti chrmarti removed their assignment Jul 31, 2018
@JacksonKearl JacksonKearl removed their assignment Jul 31, 2018
@weinand weinand changed the title Test new smartSkip behavior Test new smartStep behavior Aug 3, 2018
@vscodebot vscodebot bot locked and limited conversation to collaborators Sep 14, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
debug Debug viewlet, configurations, breakpoints, adapter issues testplan-item
Projects
None yet
Milestone
July 2018
Development

No branches or pull requests
5 participants
@weinand @RMacfarlane @sbatten @JacksonKearl @chrmarti