Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

variable.other.constant.ts only matches all-caps constant declarations #55119

Closed
Janne252 opened this issue Jul 26, 2018 · 1 comment
Closed
Assignees
Labels
typescript Typescript support issues upstream Issue identified as 'upstream' component related (exists outside of VS Code)

Comments

@Janne252
Copy link

  • VSCode Version: 1.25.1
  • OS Version: Windows 10 Pro 64-bit

Steps to Reproduce:

  1. Open an empty folder in VS Code
  2. Create a new TypeScript file with the following content:
declare const Foo: string;
declare const BAR: string;
  1. Add the following setting to the workspace settings:
    "editor.tokenColorCustomizations": {
        "textMateRules": [
            {
                "scope": "variable.other.constant.ts",
                "settings": {
                    "foreground": "#FF0000"
                }
            }
        ]   
    }
  1. Enable "Developer: Inspect TM Scopes"
  2. Inspect the TextMate scopes of the constants Foo and BAR
    image
    Note how the constant in all caps is scoped as variable.other.constant.ts
    image
    Note how the constant in camel case is incorrectly scoped as variable.other.readwrite.ts

Does this issue occur when all extensions are disabled?: Yes

@mjbvz
Copy link
Collaborator

mjbvz commented Jul 26, 2018

This issue was moved to microsoft/TypeScript-TmLanguage#641

@mjbvz mjbvz added the upstream Issue identified as 'upstream' component related (exists outside of VS Code) label Jul 26, 2018
@vscodebot vscodebot bot locked and limited conversation to collaborators Sep 9, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
typescript Typescript support issues upstream Issue identified as 'upstream' component related (exists outside of VS Code)
Projects
None yet
Development

No branches or pull requests

2 participants