Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Settings - some corrections #55413

Closed
user3323 opened this issue Jul 31, 2018 · 9 comments
Closed

New Settings - some corrections #55413

user3323 opened this issue Jul 31, 2018 · 9 comments
Assignees
Labels
editor-contrib Editor collection of extras

Comments

@user3323
Copy link

  • VSCode Version: 1.26.0-ins
  • OS Version: win7x64

new settings 1

  1. Labels should be bound to radio buttons.
  2. Look at the pre-last option when clicking on it .... it makes last option to be moved a little bit. All these "shakes" do not look good.
  3. And these outstanding blue outlines ......... what is the benefit to put them EVERYWHERE ? They are literally everywhere! They look not bad, but absolutely "cheap" and pathetic! And they visually DO NOT belong to this specific area of new settings!

one more gif:

new settings 2

And one more blue outline around the left menu! Wow.

  1. On the second GIF you can see these jumping options after you click on them.
    Well, some transition for expansion movement wouldn't hurt!

  2. Description of each option, if it's can be expanded - should be ended up with .... at least three dots?.. Or any other icon, that will inform, that it's not full.

image

image

  1. When hover a cursor over the option, that can be expanded - cursor should have pointer type, not default.

  2. When any option is clicked - background of this option should change to color a little bit lighter.

  3. Add background-color change on hover cursor movement over options and items of the left menu.

  4. Names and descriptions of the options should be selectable (for copying, etc.)

  5. Scrollbar area of the new settings is absolutely invisible. This little scrollbar thing is flying in the air.

@vscodebot vscodebot bot added editor editor-contrib Editor collection of extras labels Jul 31, 2018
@roblourens
Copy link
Member

Thanks for the feedback!

  1. I don't do this right now because someone might be clicking the description to expand it, but I plan to make some changes around that for next month, so I'll keep thinking about it.

  2. I can't repro that right now, it might have been fixed in the past couple days?

  3. The model here is that the list of settings is a list that works the same as other lists in vscode. You can use the same keybindings to navigate, only the selected setting is tabbable, and the outline shows the selected setting.

  4. I played with animations and wasn't a fan since I thought it just felt sluggish. But I'll likely switch to showing the full description all the time, and get rid of the expansion anyway.

  5. Fixed this 👍

  6. I'm not sure, it would mean that the pointer would show up basically everywhere on the page. Will think about it.

  7. We had this originally but didn't like it. Too hard to get it just right for every theme.

  8. We had that too, but also didn't like seeing rectangle backgrounds on that menu when it's not in any sort of rectangle container.

  9. I think you're right, Text is not selectable in the new Settings Editor #54694 for this

  10. This should run along the far right side of the editor, but I couldn't get the layout right. Settings editor scrollbar should be along far right edge #55795 for that.

Thanks for the feedback, and follow along with #55791 (not filled out yet) and #50249 for updates!

@user3323
Copy link
Author

user3323 commented Aug 4, 2018

@roblourens

  1. How about adding a Smooth Scrolling feature, that we have in editors, to affect on New Settings list?

image

Without smooth scrolling - it is really hard to find the line, that you were focusing on.

@roblourens
Copy link
Member

When would this apply? I don't quite follow

@user3323
Copy link
Author

user3323 commented Aug 4, 2018

@roblourens I mean look at this:

smooth scrolling

It is absolutely uncomfortable to look at these lines. Smooth scrolling (like in editors) would help.

@roblourens
Copy link
Member

The "smooth scrolling" applies to things like 'page down' or 'go to definition' that would normally just jump. I'm not sure what you're seeing exactly, it's hard to tell from the gif, but maybe just that rendering the list is not as fast as it could be. I'll keep optimizing it 👍

@user3323
Copy link
Author

user3323 commented Aug 6, 2018

@roblourens

a smooth scrolling feature is the feature, that came to us some months ago, with some of the updates...
maybe you don't use it, and you don't know what it is...

well, I don't really know how to explain you about what smooth scrolling is...

just look at it:

GIF:
smooth scrolling 2

you really don't see the difference between default scrolling and smooth scrolling ?

@roblourens
Copy link
Member

What are you scrolling with? Mouse wheel, trackpad?

I know what smooth scrolling is and I see the difference between the gifs. I think that it looks less smooth because of slow rendering, not because of a missing feature.

@user3323
Copy link
Author

user3323 commented Aug 9, 2018

@roblourens

scrolling with mouse wheel...
no, it's not rendering problem.. i can record video with 50 fps, if you need

i don't get it, are you saying that New Settings already has smooth scrolling feature?

@roblourens
Copy link
Member

You're right, I found that smooth scrolling doesn't work the way I thought and it isn't enabled on the settings editor. With my particular hardware it already looks smooth. I'll have to look into it later.

@vscodebot vscodebot bot locked and limited conversation to collaborators Sep 18, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
editor-contrib Editor collection of extras
Projects
None yet
Development

No branches or pull requests

2 participants