Repeatedly typing space in extension search box causes hang

[mjbvz]

Testing #55386

Issue Type: Bug

1. Open extension search box.
2. Repeatedly type space every half second or so (make sure the progress bar is showing when you type the next space)

Bug
After five or more spaces, the entire VS Code UI starts hanging for a few seconds

VS Code version: Code - Insiders 1.26.0-insider (0707dd4, 2018-07-31T05:12:08.688Z)
OS version: Darwin x64 17.7.0

System Info

Item	Value
CPUs	Intel(R) Core(TM) i7-4770HQ CPU @ 2.20GHz (8 x 2200)
GPU Status	2d_canvas: enabled checker_imaging: disabled_off flash_3d: enabled flash_stage3d: enabled flash_stage3d_baseline: enabled gpu_compositing: enabled multiple_raster_threads: enabled_on native_gpu_memory_buffers: enabled rasterization: enabled video_decode: enabled video_encode: enabled webgl: enabled webgl2: enabled
Load (avg)	3, 3, 5
Memory (System)	16.00GB (0.14GB free)
Process Argv	/Applications/Visual Studio Code - Insiders.app/Contents/MacOS/Electron -psn_0_9410809
Screen Reader	no
VM	17%

[JacksonKearl]

Are you able to reproduce this reliably? I've never gotten it on Windows but I did manage once on macOS, even then it only stalled the extensions viewlet UI, rest was fine. Its just pressing space as the search triggers right?

[ramya-rao-a]

@JacksonKearl Can we not skip the search if newValue.trim() === oldValue.trim() ?

[JacksonKearl]

We can do that. But what if they hit 'a' a bunch? @mjbvz can you repro this in stable?

[mjbvz]

No, I didn’t see this in stable when typing spaces. I also don’t remember being able to reproduce this with other characters, such as typing “a” many times

[JacksonKearl]

Then we can probably get away with just debouncing the trimmed value

[ramya-rao-a]

@JacksonKearl Let's do that to begin with