syntax highlighting

[LexRiver]

After the last update if I have a line with comment like this:

export /* comment */ class MyClass{
...
}

then I have a bug with syntax highlightning inside this class.
Previous version of vscode was fine.
It's a typescript *.ts file.

[Nufflee]

A screenshot could be useful here. And can you specify what version were you on when it worked wnad what version are you one now?

[LexRiver]

Screenshot is below

Current version:

Version: 1.26.1
Commit: 493869e
Date: 2018-08-16T18:38:57.434Z
Electron: 2.0.5
Chrome: 61.0.3163.100
Node.js: 8.9.3
V8: 6.1.534.41
Architecture: x64

Previous version I don't know, sorry.

[jackhorton]

This may be related to a bug I just noticed when editing ChakraCore.

https://github.com/Microsoft/ChakraCore/blob/769922256afe021177babc675774b18e9cf54cf2/lib/Runtime/Library/InJavascript/Intl.js#L593-L601

After line 595, the majority of the rest of the document is interpreted as a string. Removing the end-of-line comment does not help. This worked in 1.25.x, but I don't know if it broke with 1.26 or 1.26.1

[jackhorton]

Minimal repro:

It specifically fails when concatenating strings across newlines when the trailing + has a space after (note that I have whitespace on -- the trialing space in the failure case is important)

Perhaps I am hitting a different bug -- I can file a new issue for it. Two JS syntax highlighting errors in 1.26.x may be similar root cause, though?

[mjbvz]

@jackhorton Please open a separate issue

[mjbvz]

Opened microsoft/TypeScript-TmLanguage#650 to track this upstream

[jackhorton]

Is TypeScript-TmLanguage the preferred repo for my issue as well?

[mjbvz]

yes