Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Repetitive problem message when pointing to problem line #5792

Closed
Aukstkalnis opened this issue Apr 26, 2016 · 16 comments
Closed

Repetitive problem message when pointing to problem line #5792

Aukstkalnis opened this issue Apr 26, 2016 · 16 comments
Assignees
Labels
*duplicate Issue identified as a duplicate of another issue(s) tasks Task system issues

Comments

@Aukstkalnis
Copy link

  • VSCode Version: 1.0.0
  • OS Version: windows 7

Steps to Reproduce:

  1. In one header create warning message
  2. Include this header into multiple files
  3. Compile and go, to problem Mach in this header
  4. Problem message shows a list repetitive messages

It is strange to see list of problem messages that are the same.

@bpasero
Copy link
Member

bpasero commented Apr 26, 2016

@alexxx537 what language is this?

@bpasero bpasero added the info-needed Issue requires more information from poster label Apr 26, 2016
@Aukstkalnis
Copy link
Author

It is C language. I am using C/C++ extension.

@dbaeumer dbaeumer removed the info-needed Issue requires more information from poster label May 9, 2016
@dbaeumer dbaeumer removed their assignment May 9, 2016
@dbaeumer
Copy link
Member

dbaeumer commented May 9, 2016

This issue was moved to microsoft/vscode-cpptools#41

@dbaeumer dbaeumer closed this as completed May 9, 2016
@dbaeumer dbaeumer added the upstream Issue identified as 'upstream' component related (exists outside of VS Code) label May 9, 2016
@sridmad
Copy link
Member

sridmad commented May 27, 2016

This is not related to the C++ extension as it does not support build not does it process the output. I think this has to do with VSCode processing warnings and errors from Tasks.

@sridmad
Copy link
Member

sridmad commented May 27, 2016

@dbaeumer, @bpasero please re-open the issue as this is related to VSCode handling of Task output.

@dbaeumer
Copy link
Member

@Aukstkalnis how do you build the project ?

@dbaeumer dbaeumer reopened this May 30, 2016
@dbaeumer dbaeumer added tasks Task system issues info-needed Issue requires more information from poster and removed upstream Issue identified as 'upstream' component related (exists outside of VS Code) labels May 30, 2016
@Aukstkalnis
Copy link
Author

See this issue:
microsoft/vscode-cpptools#41

@dbaeumer
Copy link
Member

@Aukstkalnis Just to double check. The tasks.json must normally sit in a settings folder. This is the case in your setup.

@dbaeumer
Copy link
Member

Sorry a .vscode folder.

@Aukstkalnis
Copy link
Author

Yes, my task.json is in the .vscode folder which is generated in my project root directory.

@dbaeumer
Copy link
Member

I can't reproduce this using our setup. Here is what I see using version 17.x of cl:

Microsoft (R) C/C++ Optimizing Compiler Version 17.00.60610.1 for x86
Copyright (C) Microsoft Corporation.  All rights reserved.
Source.cpp
p:\mseng\vscode\playgrounds\bugs\consoleapplication1\warning.h(5) : error C2146: syntax error : missing '}' before identifier 'TestWarning_three'
p:\mseng\vscode\playgrounds\bugs\consoleapplication1\warning.h(6) : error C2059: syntax error : '}'
p:\mseng\vscode\playgrounds\bugs\consoleapplication1\warning.h(6) : error C2143: syntax error : missing ';' before '}'

Setting up the problem matcher for this pattern makes the errors show up correctly.

@Aukstkalnis how does the output of the nmake run look on your system.

@Aukstkalnis
Copy link
Author

This is my project example from microsoft/vscode-cpptools#41:
ConsoleApplication1.zip.txt

With this example I am able to reproduce this problem.

@dbaeumer
Copy link
Member

dbaeumer commented Jun 1, 2016

@Aukstkalnis could you still provide me with the output of running build.bat. You seem to call a g++ compiler and the error format mostly depends on compiler and its version.

@Aukstkalnis
Copy link
Author

I get this output:

c:\Users\aukstkalnis.de\Desktop\ConsoleApplication1>g++ -c hello.cpp
In file included from hello.cpp:1:0:
warning.h:5:5: error: expected '}' before 'TestWarning_three'
TestWarning_three
^
warning.h:6:1: error: expected initializer before '}' token
};
^
warning.h:6:1: error: expected declaration before '}' token
c:\Users\aukstkalnis.de\Desktop\ConsoleApplication1>g++ -c main.cpp
In file included from main.cpp:4:0:
warning.h:5:5: error: expected '}' before 'TestWarning_three'
TestWarning_three
^
warning.h:6:1: error: expected initializer before '}' token
};
^
warning.h:6:1: error: expected declaration before '}' token

@dbaeumer
Copy link
Member

dbaeumer commented Jun 2, 2016

@Aukstkalnis thanks. Now I see. Need to think about how to best address this.

@dbaeumer dbaeumer added bug Issue identified by VS Code Team member as probable bug and removed info-needed Issue requires more information from poster labels Jun 2, 2016
@dbaeumer dbaeumer removed the bug Issue identified by VS Code Team member as probable bug label Nov 7, 2017
@dbaeumer
Copy link
Member

dbaeumer commented Nov 7, 2017

@Aukstkalnis this got addressed a while ago by de-duping error message in the problem collector.

@dbaeumer dbaeumer closed this as completed Nov 7, 2017
@dbaeumer dbaeumer added the *duplicate Issue identified as a duplicate of another issue(s) label Nov 7, 2017
@vscodebot vscodebot bot locked and limited conversation to collaborators Dec 22, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
*duplicate Issue identified as a duplicate of another issue(s) tasks Task system issues
Projects
None yet
Development

No branches or pull requests

4 participants