Suggest widget looks weird today

[alexdima]

Maybe the suggest widget could use a smaller line height than the editor?
Also, the text and icon are not vertically centered in each row.

[alexdima]

My settings:

    , "editor.fontFamily": "Hack"
    , "editor.renderWhitespace": true
    , "editor.fontSize": 16
    , "editor.lineHeight": 22

[joaomoreno]

Yeah I did change something... Thanks for your settings, I'll take a look.

[joaomoreno]

This comes from #2465, in which the suggest widget picks up on the line height and font size of the editor itself. I've pushed some changes to alleviate the line height difference in your case. Hope this solves it in the meantime. Would you rather have additional settings, suggest.fontSize and suggest.lineHeight?

I'll leave this issue open since the suggest does need some layout work to fix the vertical alignment of the icon et al.

[joaomoreno]

Reverted the changes from #2465, since it needs more work. 👍

[alexdima]

I like your approach of deriving the font size and line height from the editor settings more than introducing separate settings.

[joaomoreno]

The problem is that the derivation is not so smooth across all platforms... gotta figure that out platform per platform. 👎