The --wait switch no longer works

[thomaslevesque]

I've been using VSCode as my Git editor for a while, with the following value for core.editor:

'C:\Program Files (x86)\Microsoft VS Code\Code.exe' --wait

It was working fine, but now Git keeps waiting after I closed the editor tab, so I suspect the process Git is waiting for is still running when it should stop.

(Using VSCode 1.28.1)

[rafalborczuch]

As a workaround you can add -n switch to force opening a new VS Code window.

[joaomoreno]

@bpasero I actually just saw this happen live when @rebornix was showing me a feature. We were on a new Windows machine.

[bpasero]

@joaomoreno @thomaslevesque are you running this from the integrated terminal?

[thomaslevesque]

@bpasero no, running from an independent terminal

[bpasero]

@thomaslevesque I cannot reproduce, here is what happens:

What is your windows version? You can find out by running winver.exe from the command line.

@rebornix can you reproduce easily?

[thomaslevesque]

@bpasero in your scenario, it's a new instance of VSCode, and closing the tab closes VSCode, so it works. In my scenario I already have a VSCode instance running. The new tab is created in the existing window, so closing it doesn't close the window.

[bpasero]

@thomaslevesque I understand, but I cannot reproduce that either.

[joaomoreno]

@bpasero It was integrated terminal using cmd.exe. Stable. Also repros in external command prompt.

[bpasero]

@joaomoreno I cannot reproduce.

LOOK HERE: Everyone, what is your exact windows version? Does it reproduce without configuring any settings?

Adding @Tyriar for the integrated terminal.

[bpasero]

@joaomoreno @thomaslevesque wait, you are not using the actual code.exe in program files to do this right? That will not work, you must be using our "code" global command.

[thomaslevesque]

Everyone, what is your exact windows version?

Windows 10 64bit v1803

Does it reproduce without configuring any settings?

What kind of settings do you mean? The Git editor settings are as described in the first message (I think this setup was done by the Git for Windows installer)

That will not work, you must be using our "code" global command.

Ah, that works! Thanks!

[joaomoreno]

wait, you are not using the actual code.exe in program files to do this right? That will not work, you must be using our "code" global command.

The machine where I saw it happening was the demo booth machine, which wasn't set up by me. It was also a shiny new windows, with pretty much nothing installed but (1) Code and (2) Git. Afaik, Git can automatically configure Code as the default editor. It is possible that they are doing the wrong thing and using code.exe as the editor value. I can't check any more, since I'm not with the machine anymore...

If this is true, we might wanna follow up with the Git for Windows guys and get them to do the right thing.

[rebornix]

@joaomoreno I still have this issue on my machine and probably we can do some troubleshooting together.

[rebornix]

Some interesting workaround mentioned in #60192 (comment)

[joaomoreno]

@bpasero That is exactly the problem. There's already an issue in the Git package: git-for-windows/git#1875