Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VSCode is not per monitor DPI aware #6196

Closed
ivanz opened this issue May 8, 2016 · 34 comments
Closed

VSCode is not per monitor DPI aware #6196

ivanz opened this issue May 8, 2016 · 34 comments
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug electron Issues and items related to Electron upstream Issue identified as 'upstream' component related (exists outside of VS Code) verified Verification succeeded
Milestone

Comments

@ivanz
Copy link
Contributor

ivanz commented May 8, 2016

  • VSCode Version: 1.0.0
  • OS Version: Windows 10

Steps to Reproduce:

  1. Connect second monitor and adjust DPI such as the second monitor has different DPI than the main one
  2. Drag Vscode window to the second monitor - UI becomes all blurry.

Possibly related to #1896 and also this upstream Chromium issue: https://bugs.chromium.org/p/chromium/issues/detail?id=426656

@bpasero bpasero added bug Issue identified by VS Code Team member as probable bug upstream Issue identified as 'upstream' component related (exists outside of VS Code) labels May 8, 2016
@bpasero bpasero self-assigned this May 8, 2016
@bpasero bpasero added this to the Backlog milestone May 8, 2016
@renomarcello
Copy link

Also happens on VSCode Version: 1.1.0-insider; OS: Windows 10 14332

@bpasero
Copy link
Member

bpasero commented Sep 18, 2016

@ivanz @Chococat could you try our latest insider release to see if this issue still reproduces?
You can give our preview releases a try from: http://code.visualstudio.com/Download#insiders

@ivanz
Copy link
Contributor Author

ivanz commented Sep 20, 2016

@bpasero Not as far as I can tell. You can easily test this without multiple monitors on Windows by simply changing the size of text etc. As far as I can tell the work is still in progress on the Chromium side here and is currently available in their dev and canary builds only.

image

@bpasero
Copy link
Member

bpasero commented Sep 20, 2016

Ok but good to know they plan for it because that means we will eventually also benefit.

@bpasero
Copy link
Member

bpasero commented Nov 21, 2016

@ivanz we recently updated Chrome again to 53 in our insider builds, maybe this improved?
You can give our preview releases a try from: http://code.visualstudio.com/Download#insiders

@ivanz
Copy link
Contributor Author

ivanz commented Nov 21, 2016

@bpasero No improvement with 53. I believe that the proper DPI support may land in 55 or later. Chrome Beta (which is 55) has it enabled by default, but no idea what that means for chromium stable.

@bpasero
Copy link
Member

bpasero commented Nov 22, 2016

Got it, thanks 👍

@Ciantic
Copy link

Ciantic commented Nov 23, 2016

This is bothering, I'm running Google Chrome 54, and it works perfectly but not the Electron which is running with Chromium 53. I opened issue to Electron electron/electron#8062

P.S. I have own Electron app too, which is now running with 1.4.8 and it suffers the same problem. The 1.4.x is not going to solve this.

@retrixe
Copy link

retrixe commented Jan 28, 2017

Electron 1.5 fixes this by updating to Chrome 54.

@bpasero bpasero added the electron Issues and items related to Electron label Mar 8, 2017
@bpasero bpasero added workbench and removed workbench bug Issue identified by VS Code Team member as probable bug labels Apr 7, 2017
@bpasero
Copy link
Member

bpasero commented Apr 10, 2017

Todays VS Code insider build comes with Electron 1.6.x, would be interesting to hear if this update solves this issue for anyone: http://code.visualstudio.com/Download#insiders

@ivanz
Copy link
Contributor Author

ivanz commented Apr 10, 2017

I am afraid not. I changed the DPI of one of my monitors and with build from sha 61753c029226f43c12124a75020b5d8b86c60700 and date 2017-04-10T07:15:44.057Z when I drag across monitors VSCode becomes blurry. :(

@rhyek
Copy link

rhyek commented Apr 10, 2017

Electron still hasn't resolved this on their end, right? electron/electron#5429

@bpasero
Copy link
Member

bpasero commented Apr 10, 2017

True that, would still be happy for more people trying out this new electron release.

@miparnisari
Copy link

@bpasero it does for me :) I have a Surface Book and the Explorer panel used to look super tiny, now it's fine.

@ivanz
Copy link
Contributor Author

ivanz commented May 18, 2017

The default scaling factor ("zoom") is now more sensible out of the box (guess DPI aware) indeed.

@jnm2
Copy link

jnm2 commented May 18, 2017

It's now system DPI aware, but not yet per-monitor DPI aware.

@yume-chan
Copy link
Contributor

Recently I started a test project with Electron, and I found it's now Per-Monitor Aware.

I'm using Electron 1.6.10, Renderer 56.0.2924.87, while VS Code 1.12.2 is using Electron 1.6.6 and same Renderer 56.0.2924.87.

capture

Maybe another upgrade required? It's really annoying.

@jnm2
Copy link

jnm2 commented Jun 2, 2017

I temporarily have a setup with mixed-DPI screens and it is really annoying that VS Code isn't per-monitor DPI aware.

@wryun
Copy link

wryun commented Jul 6, 2017

This is supposedly fixed in Electron 1.6.7: https://github.com/electron/electron/releases/tag/v1.6.7

Enabled per-monitor DPI awareness in the app manifest. electron/electron#8786

@wryun
Copy link

wryun commented Jul 6, 2017

(any chance of updating to the latest 1.6.x in the near term?)

@bpasero
Copy link
Member

bpasero commented Jul 7, 2017

Updating to Electron 1.7.x is on the plan for July.

@kring
Copy link

kring commented Aug 15, 2017

I just found a great workaround for this that might be helpful to others. You will need a recent build of Windows 10. Find the shortcut you use to launch Visual Studio Code, right click on it and choose Properties. Go to the Compatibility tab, check the "Override high DPI scaling behavior" checkbox, and choose Scaling performed by "Application". Close and restart Visual Studio Code.
image

Now, when you drag VS Code between monitors with different DPI, it will initially fail to resize the text. So going from a high DPI screen to a low DPI screen, the text will apear huge. But all you have to do is resize the window on the new monitor and the text will instantly size properly for the monitor and be perfectly sharp.

@yume-chan
Copy link
Contributor

@kring I have heard that choose System (Enhanced) will also work.

But anyway, after a month of postpone, Electron 1.7.4 is now in the master branch, so Insider builds from today should be per-monitor DPI aware now, at least in theory.

@bpasero
Copy link
Member

bpasero commented Aug 15, 2017

@kring (and others), yeah let us know if the insiders build (e.g. from today) fixes this.

@kring
Copy link

kring commented Aug 15, 2017

Yep today's Insiders looks great, no settings tweak or manual resize necessary. Thanks!

@bpasero bpasero modified the milestones: August 2017, Backlog Aug 21, 2017
@bpasero bpasero added electron-update bug Issue identified by VS Code Team member as probable bug labels Aug 21, 2017
@bpasero bpasero closed this as completed Aug 21, 2017
@bpasero
Copy link
Member

bpasero commented Aug 30, 2017

Marking as verified based on @kring comment.

@bpasero bpasero added the verified Verification succeeded label Aug 30, 2017
@yaomtc
Copy link

yaomtc commented Sep 8, 2017

After testing many text editors, this and Notepad are the only ones I could find that have per monitor DPI awareness, which is a big help to me, with a 4K monitor next to a 1080p one. Since Notepad still doesn't support Unix style line endings, and I often create text files on Linux, MacOS, and Android, that was not an option. I'm now using Visual Studio Code as my text editor for all my personal notes and lists. I am not a programmer, but I'm very glad VS Code now works this way. Many thanks to the Electron team for fixing this and to you folks making it work with Code.

@ghost
Copy link

ghost commented Nov 1, 2017

Windows 8.1 x64, VS Code 1.17.2 x64, external 20" HP monitor @1600x900, here is a screenshot with VS Code on the left and Notepad++ on the right.

vsc-blurry

This is basically unusable, too blurry. Will this ever be fixed? I really want to use VS Code.

@jnm2
Copy link

jnm2 commented Nov 1, 2017

@alper6 VS Code has not done that for a while on any of my computers. As I drag it between monitors with different DPIs, it rescales so that it never becomes blurry. What version are you using?

@ghost
Copy link

ghost commented Nov 1, 2017

@jnm2 the version is 1.17.2. I periodically test every latest version to see if anything has improved.

@ivanz
Copy link
Contributor Author

ivanz commented Nov 1, 2017

Random thing to check: Have you by any chance maybe set a "Custom scaling" in Windows for the monitor or any monitor? I think that turns off lots of multi-DPI goodness in Windows 10 and reverts back to legacy behavior (not 100% sure).

Edit: I use VSCode on a daily basis with laptop and 2 monitors. Currently running Windows 10 Creators Update and just made all 3 monitors different DPI and it VSCode rescales fine across.

@ghost
Copy link

ghost commented Nov 1, 2017

@ivanz I mentioned details about my system in first post, top of screenshot (is it not visible?)
It's not Windows 10, but Windows 8.1
I'm not using multi-monitor, it's set as "show desktop only on 2nd monitor", here's a shot:

ss1

There's also no custom scaling, those settings are all at default, here's a shot:

ss2

@jnm2
Copy link

jnm2 commented Nov 1, 2017

Your Notepad++ is super blurry in your first screenshot too.

@delcon
Copy link

delcon commented Nov 7, 2017

I would like to reopen this issue.
VSCode seems to support 'per monitor aware scaling', at my surface.
Link to some explanation about scaling modes.
However, Tooltips and Dialog Boxes are still only system aware.
image

@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 17, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug electron Issues and items related to Electron upstream Issue identified as 'upstream' component related (exists outside of VS Code) verified Verification succeeded
Projects
None yet
Development

No branches or pull requests