Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Alert when developing an extension that uses the vscode.previewHtml command #62685

Closed
mjbvz opened this issue Nov 6, 2018 · 1 comment
Closed

Alert when developing an extension that uses the vscode.previewHtml command #62685

mjbvz opened this issue Nov 6, 2018 · 1 comment
Assignees
@mjbvz
Labels
engineering VS Code - Build / issue tracking / etc. verification-needed Verification of issue is requested verified Verification succeeded
Milestone
November 2018

Comments

@mjbvz
Copy link
Collaborator

mjbvz commented Nov 6, 2018 •
edited
Loading

Part of #62630

Feature
Show an alert when a developer is running an extension that calls the vscode.previewHtml command. This should only happen for extensions being run in development mode

The goal is to alert developers to the fact that vscode.previewHtml is deprecated and will stop working properly in the future
@mjbvz mjbvz added the engineering VS Code - Build / issue tracking / etc. label Nov 6, 2018
@mjbvz mjbvz self-assigned this Nov 6, 2018
@mjbvz mjbvz added the verification-needed Verification of issue is requested label Nov 6, 2018
@mjbvz mjbvz added this to the November 2018 milestone Nov 7, 2018
@mjbvz mjbvz closed this as completed in 9e8719b Nov 7, 2018
@RMacfarlane RMacfarlane added verified Verification succeeded and removed verified Verification succeeded labels Nov 9, 2018
@roblourens roblourens added the verified Verification succeeded label Dec 5, 2018
@roblourens
Copy link
Member

Side note, the sample previewHtml extension doesn't work anymore.

Unable to open 'CSS Property Preview': Cannot read property 'document' of undefined.

@vscodebot vscodebot bot locked and limited conversation to collaborators Dec 23, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@mjbvz mjbvz

Labels
engineering VS Code - Build / issue tracking / etc. verification-needed Verification of issue is requested verified Verification succeeded
Projects
None yet
Milestone
November 2018
Development

No branches or pull requests
3 participants
@roblourens @RMacfarlane @mjbvz